Minor logging additions #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nulltoken
commented
Jan 22, 2025
•
nulltoken
commented
- Favor UTC date format when logging (Follow-up to fix: Use better time format and fix sample app (fixes #173) #174)
- Enrich StartupJobManager with logs
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
nulltoken
commented
Jan 22, 2025
| @@ -50,4 +57,10 @@ public async Task ProcessStartupJobs(CancellationToken stopToken) | |||
|
|
|||
| private async Task CreateExecutionTask(JobRun job, CancellationToken stopToken) => | |||
| await jobProcessor.ProcessJobAsync(job, stopToken).ConfigureAwait(false); | |||
|
|
|||
| [LoggerMessage(LogLevel.Information, "Triggering startup jobs execution at {at:o}")] | |||
There was a problem hiding this comment.
As they're only going to be logged once, I figured using a Information log level would work. Thoughts?
@linkdotnet BTW, those links don't seem to work anymore. All I got are 404s. |
Same here. I hope that is just a bug and they fix that. It does work on main |
linkdotnet
reviewed
Jan 23, 2025
| @@ -195,13 +195,13 @@ private void HandleUpdate(object? sender, NotifyCollectionChangedEventArgs e) | |||
| case NotifyCollectionChangedAction.Add: | |||
| foreach (JobRun job in e.NewItems!) | |||
| { | |||
| LogJobAddedToQueue(job.JobDefinition.Type.Name, job.RunAt?.LocalDateTime); | |||
| LogJobAddedToQueue(job.JobDefinition.Type.Name, job.RunAt); | |||
linkdotnet
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.