Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AWS policy #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve AWS policy #64

wants to merge 1 commit into from

Conversation

liningpan
Copy link

I have 2 suggested changes for provided S3/KMS policies.

  • When performing multipart upload, the underlying library might need to abort the copy/upload, which requires a different action in the policy document. I haven't encountered any error caused by the missing the s3:AbortMultipartUpload action, possibly because the threshold is set to 5GiB.
  • The scope of the KMS policy is too broad. We could narrow it down and only allow the NDA account to use it with a specific S3 bucket. I tested this rule and can confirm it still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liningpan