Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing math-attributes #327

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Add missing math-attributes #327

merged 2 commits into from
Nov 1, 2023

Conversation

gunnarvelle
Copy link
Member

@gunnarvelle gunnarvelle commented Nov 1, 2023 •
edited
Loading

Trengs for å kunne lagre/publisere artikler med matte. Verdier henta fra mathml-rules.json.

@gunnarvelle gunnarvelle requested a review from a team November 1, 2023 10:26
@gunnarvelle gunnarvelle marked this pull request as ready for review November 1, 2023 10:26
jnatten
jnatten approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@jnatten jnatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Kanskje vi kunne laget en test for å sjekke om alt som er definert lovlig går an å deserialisere?

@gunnarvelle
Copy link
Member Author

Det er sikkert lurt. Kan ta det som egen oppgave.

@gunnarvelle gunnarvelle merged commit d9ec9de into master Nov 1, 2023
@gunnarvelle gunnarvelle deleted the fix-math-validation branch November 1, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnatten jnatten jnatten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunnarvelle @jnatten