-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft-api/article-api: Add disclaimer field #562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrinewi
force-pushed
the
disclaimer-field
branch
4 times, most recently
from
December 13, 2024 12:23
9ae5abd
to
997d2e4
Compare
gunnarvelle
reviewed
Dec 13, 2024
draft-api/src/main/scala/no/ndla/draftapi/model/api/DisclaimerDTO.scala
Outdated
Show resolved
Hide resolved
gunnarvelle
reviewed
Dec 16, 2024
draft-api/src/main/scala/no/ndla/draftapi/model/api/UpdatedArticleDTO.scala
Outdated
Show resolved
Hide resolved
draft-api/src/main/scala/no/ndla/draftapi/service/ConverterService.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/no/ndla/common/model/domain/article/Article.scala
Outdated
Show resolved
Hide resolved
katrinewi
force-pushed
the
disclaimer-field
branch
4 times, most recently
from
December 16, 2024 13:11
d754dc5
to
7d05044
Compare
katrinewi
force-pushed
the
disclaimer-field
branch
from
December 16, 2024 13:34
7d05044
to
2a98bbe
Compare
jnatten
reviewed
Dec 17, 2024
article-api/src/test/scala/no/ndla/articleapi/validation/ContentValidatorTest.scala
Outdated
Show resolved
Hide resolved
draft-api/src/main/scala/no/ndla/draftapi/service/ConverterService.scala
Outdated
Show resolved
Hide resolved
katrinewi
force-pushed
the
disclaimer-field
branch
from
December 17, 2024 14:21
5f4428b
to
894d7de
Compare
jnatten
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gunnarvelle
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/NDLANO/Issues/issues/4246