Convert disclaimer to new OptLanguageFields type
#578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully these types will be used with all stored language fields in the future.
This patch adds a migration of disclaimer to `OptLanguageFields` as well as retypes the `diclaimer` of the domain type to `OptLanguageFields`.
gunnarvelle
reviewed
Jan 16, 2025
Comment on lines
30
to
37
| val oldArticle = parser.parse(document).toTry.get | ||
| oldArticle.hcursor.downField(fieldName).focus match { | ||
| case None => addEmptyLanguageField(oldArticle) | ||
| case Some(f) if f.isNull => addEmptyLanguageField(oldArticle) | ||
| case Some(disclaimers) => | ||
| val disclaimerVector = disclaimers.asArray.get | ||
| val converted = convertOldLanguageField(disclaimerVector) | ||
| val newArticle = oldArticle.withObject(_.remove(fieldName).add(fieldName, converted).toJson) |
There was a problem hiding this comment.
Denne er vel generisk så kanskje navna også skal være det? oldDocument og Some(values)
Ed forholder ikke seg noe annerledes til dette egentlig. Så ja, om man sender inn tom-streng (i alle fall i disclaimer sitt tilfelle) så blir det lagret som |
jnatten
force-pushed
the
optional-language-rework
branch
from
30af8ca to
ab6e40a
Compare
gunnarvelle
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denne PR'en er større enn den trenger å være for å fikse problemet, men jeg tror språktypene kan bli enklere å jobbe med i fremtiden!
Min drøm er at alle språktypene våre kan konverteres til denne (Evt
LanguageFieldstypen som er veldig lik).Sånn det funker:
LanguageFields(Opt og ikke) serialiseres til et objekt istedenfor en liste.Feks:
{ "nb": "Dette er en bokmål disclaimer", "nn": "Dette er ein nynorsk disclaimer" }Den som heter
OptLanguageFieldslar deg også definere at et språk ikke skal ha en variant.Feks lar det oss gjøre at disclaimer kan ha en bokmål versjon, og nynorsk versjonen fallbacker til bokmål, mens engelsk har ingenting og returnerer heller ingen fallback.