myndla-api: Add arenaAccepted flag on myndla users
#580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnatten
commented
Jan 21, 2025
Comment on lines
+246
to
+250
| val arenaAccepted = updatedUser.arenaAccept match { | ||
| case Some(true) if arenaEnabled => true | ||
| case Some(false) => false | ||
| case _ => domainUserData.arenaAccepted | ||
| } |
There was a problem hiding this comment.
Skal det være mulig å trekke tilbake godkjenningen? 🤔
There was a problem hiding this comment.
Ja, men då bør vi egentlig legge til at om du trekker tilbake godjenning så må brukeren slettes i nodebb.
There was a problem hiding this comment.
Kanskje legge inn en TODO på det.
There was a problem hiding this comment.
Jeg ser for meg at en todo som bare lever i kodebasen vil bli liggende for alltid om vi ikke har noe system for å fikse de.
Men kanskje lage et issue? 😄
There was a problem hiding this comment.
This is currently just a dumb boolean field that a user can set that the frontend can use to determine whether or not it should link to arena.
jnatten
force-pushed
the
4269-myndlauser-arena-flag
branch
from
7af794a to
e1e8f45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NDLANO/Issues#4269