Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File to new embed type #1779

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

File to new embed type #1779

wants to merge 2 commits into from

Conversation

Jonas-C
Copy link
Contributor

@Jonas-C Jonas-C commented Apr 11, 2023

Fikser også en bug som ble innført i nye arrMove. Den oppstod hvis man flyttet arr[1] til arr[0].
Avhengig av NDLANO/frontend-packages#1608

@cypress
Copy link

cypress bot commented Apr 11, 2023

Passing run #11371 ↗︎

0 52 0 0 Flakiness 0

Details:

Merge 7e8917c into d699f4a...
Project: editorial-frontend Commit: b2731201fc ℹ️
Status: Passed Duration: 14:30 💡
Started: Apr 11, 2023 12:04 PM Ended: Apr 11, 2023 12:18 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Apr 11, 2023

Passing run #11370 ↗︎

0 52 0 0 Flakiness 0

Details:

Fix arrMove function. Add more arrMove tests
Project: editorial-frontend Commit: 7e8917c7d0
Status: Passed Duration: 10:11 💡
Started: Apr 11, 2023 12:04 PM Ended: Apr 11, 2023 12:14 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Jonas-C Jonas-C requested a review from a team April 11, 2023 12:02
@Jonas-C Jonas-C marked this pull request as ready for review April 11, 2023 12:02
const formatFile = (file: File, t: TFunction): File => ({
...file,
formats: [
{ url: file.url, fileType: file.type, tooltip: `${t(`form.file.download`)} ${file.title}` },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du mister gjerne tooltipen som er satt her.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff, det er sant. Jeg tok bare hensyn til nye FileList. Skal tenke litt på en god løsning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants