Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use new accordions #2458

Merged
merged 2 commits into from
Oct 9, 2024
Merged

refactor: use new accordions #2458

merged 2 commits into from
Oct 9, 2024

Conversation

Jonas-C
Copy link
Contributor

@Jonas-C Jonas-C commented Sep 26, 2024

Skriver om FormAccordion og gjør en bitteliten redesign av versjonslogger. Måtte desverre gjøre noen layout-endringer i editorene for å få ting til å se tålelig greit ut. Når denne er inne kommer det en oppfølgnings-PR som sørger for at knappene i editoren alltid er synlig.

Ting som må sjekkes:

  • At endringene i versjonsloggen er akseptable
  • At alle knapper i skjema er synlige (gjelder ikke embed-knapper i hoved-editor, men heller knapper i f.eks bilde-editor)

@Jonas-C Jonas-C requested a review from a team September 26, 2024 11:49
@katrinewi
Copy link
Contributor

Burde versjonslogg ta full bredde?

@Jonas-C
Copy link
Contributor Author

Jonas-C commented Sep 30, 2024

Burde versjonslogg ta full bredde?

Tabellen, tenker du på? Litt usikker. Nå bruker den jo bare "standard" tabell-styling.

@katrinewi
Copy link
Contributor

Burde versjonslogg ta full bredde?

Tabellen, tenker du på? Litt usikker. Nå bruker den jo bare "standard" tabell-styling.

Tabellen ja, jeg syntes det så litt rotete ut 🤔

@Jonas-C Jonas-C force-pushed the feat/new-accordion branch 4 times, most recently from 8e8a9e2 to ea2048b Compare October 8, 2024 14:15
@Jonas-C Jonas-C requested a review from katrinewi October 8, 2024 14:16
@katrinewi
Copy link
Contributor

Posisjonering av slett-knapp her burde fikses (image-form)
Skjermbilde 2024-10-09 kl  09 06 04

@Jonas-C Jonas-C force-pushed the feat/new-accordion branch from ea2048b to 20d418d Compare October 9, 2024 09:22
@Jonas-C Jonas-C force-pushed the feat/new-accordion branch from 20d418d to d51e1e0 Compare October 9, 2024 09:26
@Jonas-C
Copy link
Contributor Author

Jonas-C commented Oct 9, 2024

Oppdatert!

@Jonas-C Jonas-C merged commit 9d50f97 into master Oct 9, 2024
4 checks passed
@Jonas-C Jonas-C deleted the feat/new-accordion branch October 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants