-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: redesign quality evaluation #2478
Conversation
Jeg vet ikke om jeg er heeelt fan av hvordan dette ser ut nå, særlig formen var ikke så veldig pen😿 Kan vi hvertfall gjøre boksene like store? Også er det noe med fargene 😅 |
3daf724
to
72f647d
Compare
Hva er planen med denne? |
Å vente på at Hedvig kommer med nye farger :') |
a9aee2d
to
80b080a
Compare
orientation="horizontal" | ||
<FieldRoot invalid={!!meta.error} required> | ||
<RadioGroupRoot | ||
orientation="vertical" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hvorfor?
80b080a
to
d5e3d92
Compare
import { QualityEvaluationValue } from "../../../components/QualityEvaluation/QualityEvaluationForm"; | ||
|
||
// TODO: We should change these colors | ||
const qualityEvaluationOptions: Record<QualityEvaluationValue, string> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dette er duplisert :/
variants: { | ||
quality: { | ||
"1": { | ||
borderColor: qualityEvaluationOptions["1"], | ||
}, | ||
|
||
"2": { | ||
borderColor: qualityEvaluationOptions["2"], | ||
}, | ||
|
||
"3": { | ||
borderColor: qualityEvaluationOptions["3"], | ||
}, | ||
"4": { | ||
borderColor: qualityEvaluationOptions["4"], | ||
}, | ||
"5": { | ||
borderColor: qualityEvaluationOptions["5"], | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hadde det også vært mulig å definere dette kun et sted og gjenbrukt både i QualityEvaluationForm
og QualityEvaluationGrade
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syntes det ser bra ut nå! 😄 burde dette sjekkes med BM før vi tar det inn?
Mistenker at dette kommer til å være den kjipeste radio-knappen å kvitte seg med, så tenkte det var like greit å starte med den. Er vel Katrine som har rørt mest med dette, så setter hun som eneste reviewer.