Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redesign quality evaluation #2478

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

Jonas-C
Copy link
Contributor

@Jonas-C Jonas-C commented Oct 7, 2024

Mistenker at dette kommer til å være den kjipeste radio-knappen å kvitte seg med, så tenkte det var like greit å starte med den. Er vel Katrine som har rørt mest med dette, så setter hun som eneste reviewer.

@Jonas-C Jonas-C requested a review from katrinewi October 7, 2024 14:37
@katrinewi
Copy link
Contributor

Jeg vet ikke om jeg er heeelt fan av hvordan dette ser ut nå, særlig formen var ikke så veldig pen😿 Kan vi hvertfall gjøre boksene like store? Også er det noe med fargene 😅

@Jonas-C Jonas-C force-pushed the refactor/new-quality-evaluation branch from 3daf724 to 72f647d Compare October 8, 2024 07:20
@katrinewi
Copy link
Contributor

Hva er planen med denne?

@Jonas-C
Copy link
Contributor Author

Jonas-C commented Oct 9, 2024

Hva er planen med denne?

Å vente på at Hedvig kommer med nye farger :')

@Jonas-C Jonas-C force-pushed the refactor/new-quality-evaluation branch 2 times, most recently from a9aee2d to 80b080a Compare October 31, 2024 14:48
orientation="horizontal"
<FieldRoot invalid={!!meta.error} required>
<RadioGroupRoot
orientation="vertical"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hvorfor?

@Jonas-C Jonas-C force-pushed the refactor/new-quality-evaluation branch from 80b080a to d5e3d92 Compare October 31, 2024 15:49
import { QualityEvaluationValue } from "../../../components/QualityEvaluation/QualityEvaluationForm";

// TODO: We should change these colors
const qualityEvaluationOptions: Record<QualityEvaluationValue, string> = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette er duplisert :/

Comment on lines 30 to 50
variants: {
quality: {
"1": {
borderColor: qualityEvaluationOptions["1"],
},

"2": {
borderColor: qualityEvaluationOptions["2"],
},

"3": {
borderColor: qualityEvaluationOptions["3"],
},
"4": {
borderColor: qualityEvaluationOptions["4"],
},
"5": {
borderColor: qualityEvaluationOptions["5"],
},
},
},
Copy link
Contributor

@katrinewi katrinewi Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadde det også vært mulig å definere dette kun et sted og gjenbrukt både i QualityEvaluationForm og QualityEvaluationGrade?

Copy link
Contributor

@katrinewi katrinewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntes det ser bra ut nå! 😄 burde dette sjekkes med BM før vi tar det inn?

@Jonas-C Jonas-C merged commit f87502a into master Nov 1, 2024
4 checks passed
@Jonas-C Jonas-C deleted the refactor/new-quality-evaluation branch November 1, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants