Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express 5 #2484

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Express 5 #2484

merged 3 commits into from
Oct 10, 2024

Conversation

jnatten
Copy link
Contributor

@jnatten jnatten commented Oct 8, 2024

Ca det samme som NDLANO/ndla-frontend#2144

Med tillegg at jeg dro ut express-jwt kallet til en funksjon som gjenbrukes 😄

This will start the application without running typescript checking
concurrently. Nice if you want to pipe the logs somewhere.
src/server/api.ts Outdated Show resolved Hide resolved
Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liten pirk, men ellers så fungerer det.

@Jonas-C
Copy link
Contributor

Jonas-C commented Oct 8, 2024

HTML-formatering funker ikke!

@jnatten
Copy link
Contributor Author

jnatten commented Oct 9, 2024

HTML-formatering funker ikke!

Fixat. Var json parsing setupet som var helt på tuppa

The old setup was weird, but in express 5 it didn't even work.
@jnatten jnatten requested review from Jonas-C and gunnarvelle October 9, 2024 12:53
Copy link
Contributor

@Jonas-C Jonas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Så lenge Gunnar går god for dette csp-greiene!

@jnatten
Copy link
Contributor Author

jnatten commented Oct 10, 2024

Så lenge Gunnar går god for dette csp-greiene!

Det vil ikke påvirkes her, men gunnar har lagd en pr på det også. 😄

@jnatten jnatten merged commit 508b598 into master Oct 10, 2024
4 checks passed
@jnatten jnatten deleted the express5 branch October 10, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants