Add possibility to add multiple grep codes with comma as separator #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarvelle
reviewed
Jan 9, 2025
|
Det funker men kodene du skreiv inn blir stående i tekstfeltet. |
Kan godt nullstille innholdet i søkebaren når man klikker enter, men ønsker vi egentlig det? |
Co-authored-by: Gunnar Velle <[email protected]>
Jonas-C
reviewed
Jan 10, 2025
| }, [] as string[]); | ||
| if (!addedGrepCodes.length) return; | ||
|
|
||
| const grepPromises = addedGrepCodes.map(async (v) => await fetchGrepCodeTitles(v)); |
There was a problem hiding this comment.
Dette virket ineffektivt. Hvorfor kan vi ikke bare gjøre et søk med alle grepkodene?
There was a problem hiding this comment.
Krever litt mer error handling-logikk på klient, men godt poeng! Pushet et forslag nå!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.