Merge pull request #229 from NDLANO/3778-bump-node-18

Bumped to Node20
NDLANO · Nov 20, 2023 · e9b2e32 · e9b2e32
2 parents 87199db + c4d7aec
commit e9b2e32
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: '18.18'
+          node-version: '20.9'
       - name: 'Login to ECR repo'
         run:
           RES=$(aws sts assume-role --role-arn $CI_RELEASE_ROLE --role-session-name github-actions-ecr-login)

diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:18.18-alpine as builder
+FROM node:20.9.0-alpine3.18 as builder
 
 ENV HOME=/home/app
 ENV APP_PATH=$HOME/listing-frontend
@@ -22,7 +22,7 @@ COPY public $APP_PATH/public
 RUN yarn run build
 
 # Run stage
-FROM node:18.18-alpine
+FROM node:20.9.0-alpine3.18
 
 ENV HOME=/home/app
 ENV APP_PATH=$HOME/listing-frontend

diff --git a/package.json b/package.json
@@ -28,8 +28,8 @@
     ]
   },
   "engines": {
-    "node": ">=18.18.0",
-    "npm": ">=6.14.11"
+    "node": ">=20.9.0",
+    "npm": ">=9.0.0"
   },
   "devDependencies": {
     "@babel/cli": "^7.11.6",