Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onEnter now selects the resource #2306

Merged
merged 7 commits into from
Jan 17, 2025
Merged

onEnter now selects the resource #2306

merged 7 commits into from
Jan 17, 2025

Conversation

MaPoKen
Copy link
Contributor

@MaPoKen MaPoKen commented Jan 10, 2025

Legger til onEnter funksjonalitet så du kan trykke enter på en highlighta ressurs

@MaPoKen MaPoKen requested a review from a team January 10, 2025 08:48
@Jonas-C
Copy link
Contributor

Jonas-C commented Jan 13, 2025 •
edited
Loading

Skal vi ikke ha paginering her? Synes også det er litt merkelig at søketreff-teksten ligger utenfor ComboboxContent

@katrinewi
Copy link
Contributor

Hva med å bruke liten size på knappene i pagination? og kanskje bare bruke chevron og droppe neste/forrige? Også må du fikse mobilvisning!

@katrinewi
Copy link
Contributor

katrinewi commented Jan 15, 2025 •
edited
Loading

Også er det noe rart med hvordan ListItems rendres 😅
Skjermbilde 2025-01-15 kl 14 40 58

@katrinewi
Copy link
Contributor

aria-label på pagination nav er ikke helt riktig 😅

@MaPoKen MaPoKen merged commit 8ed93e2 into master Jan 17, 2025
6 checks passed
@MaPoKen MaPoKen deleted the learningpath-enter-selects-resource-resorucePicker branch January 17, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katrinewi katrinewi katrinewi approved these changes

@gunnarvelle gunnarvelle Awaiting requested review from gunnarvelle

@Jonas-C Jonas-C Awaiting requested review from Jonas-C

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaPoKen @Jonas-C @katrinewi @gunnarvelle