Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgraded cargo-near to the latest version #157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

frol
Copy link
Collaborator

@frol frol commented Jan 28, 2025

No description provided.

@frol frol force-pushed the fix/latest-cargo-near-support branch from 9149877 to 64dfdff Compare January 28, 2025 22:37
@frol frol force-pushed the fix/latest-cargo-near-support branch from 64dfdff to d200b85 Compare January 28, 2025 22:38
near-sdk = "5.5.0"
near-contract-standards = "5.5.0"
near-sdk = "5.7.0"
near-contract-standards = "5.7.0"
devhub_common = { path = "./devhub_common" }
cargo-near-build = "0.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workspace version needs a bump to latest, as deployed subcontract won't work on 1.84

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch seems to be following a similar path, albeit a different destination https://github.com/dj8yfo/neardevhub-contract/tree/test_workspaces_0.17_precondition .
it doesn't have .github/workflows/main.yml and .github/workflows/release.yml updates

near-workspaces = { version = "0.14.0", features = ["unstable"], default-features = false }
near-workspaces = { version = "0.14.0", features = [
"unstable",
], default-features = false }
cargo-near-build.workspace = true
Copy link
Contributor

@dj8yfo dj8yfo Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this [dev-dependency] can be removed and near_workspaces re-exported version used instead

Comment on lines 25 to +36
[package.metadata.near.reproducible_build]
# docker image, descriptor of build environment
image = "sourcescan/cargo-near:0.8.2-rust-1.81.0"
image = "sourcescan/cargo-near:0.13.2-rust-1.84.0"
# tag after colon above serves only descriptive purpose; image is identified by digest
image_digest = "sha256:3b5e6efa1d0cef710009f9cc20c845d316187cc170455edc5ba7fdf471c19655"
# build command inside of docker container
# if docker image from default gallery is used https://hub.docker.com/r/sourcescan/cargo-near/tags,
# the command may be any combination of flags of `cargo-near`,
# supported by respective version of binary inside the container besides `--no-locked` flag
container_build_command = ["cargo", "near", "build"]
image_digest = "sha256:b41cb89907f92b114da9e2be4e109bff30ab792c22ddcbd2a4cff8e340cb9acb"
container_build_command = [
"cargo",
"near",
"build",
"non-reproducible-wasm",
"--locked",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same blocks with same image can be added to disucssions and community manifests, as in commit,
to allow nearblocks+sourcescan verification of any new subcontracts , deployed from community-factory,
which currently runs cargo near build as verification implementation.

First community-factory would've to be redeployed , though, as https://nearblocks.io/address/community.devhub.near?tab=contract shows it hasn't been deployed after #151 merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants