Fix red flashes, init to [] rather than {} and hide open roles (#370)

* fix red flashes, init to [] rather than {} and hide open roles * fix formatting
NEARBuilders · Jun 11, 2024 · 1b5ef70 · 1b5ef70
1 parent 801ad4b
commit 1b5ef70
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 39 deletions.
diff --git a/apps/new/widget/page/projects/Involved.jsx b/apps/new/widget/page/projects/Involved.jsx
@@ -13,14 +13,10 @@ if (!context.accountId) {
 const { fetchProjects } = VM.require(
   "${config_account}/widget/lib.projects",
 ) || {
-  fetchProjects: () => {},
+  fetchProjects: () => [],
 };
 
-if (!fetchProjects) {
-  return "";
-}
-
-const projects = fetchProjects() || [];
+const projects = fetchProjects();
 
 projects = projects.filter((project) =>
   project.contributors.includes(context.accountId),

diff --git a/apps/new/widget/page/projects/List.jsx b/apps/new/widget/page/projects/List.jsx
@@ -5,18 +5,10 @@ const { Button } = VM.require("${alias_old}/widget/components") || {
 const { fetchProjects } = VM.require(
   "${config_account}/widget/lib.projects",
 ) || {
-  fetchProjects: () => {},
+  fetchProjects: () => [],
 };
 
-if (!fetchProjects) {
-  return "";
-}
-
-const projects = fetchProjects() || [];
-
-if (!projects) {
-  return "";
-}
+const projects = fetchProjects();
 
 return (
   <Widget

diff --git a/apps/new/widget/page/projects/MainViewContainer.jsx b/apps/new/widget/page/projects/MainViewContainer.jsx
@@ -205,7 +205,10 @@ return (
               Create Project
             </Button>
           )}
-          {showOpenRoles && <Button>Open Roles</Button>}
+          {/*
+            Commenting out until roles feature is included
+           {showOpenRoles && <Button>Open Roles</Button>}
+           */}
         </div>
       </div>
       <p>{description}</p>

diff --git a/apps/new/widget/page/projects/MyProjects.jsx b/apps/new/widget/page/projects/MyProjects.jsx
@@ -13,22 +13,14 @@ if (!context.accountId) {
 const { fetchProjects } = VM.require(
   "${config_account}/widget/lib.projects",
 ) || {
-  fetchProjects: () => {},
+  fetchProjects: () => [],
 };
 
-if (!fetchProjects) {
-  return "";
-}
-
-const projects = fetchProjects() || [];
+const projects = fetchProjects();
 projects = projects.filter(
   (project) => project.accountId === context.accountId,
 );
 
-if (!projects) {
-  return "";
-}
-
 return (
   <Widget
     src="${config_account}/widget/page.projects.MainViewContainer"

diff --git a/apps/new/widget/page/projects/Watchlist.jsx b/apps/new/widget/page/projects/Watchlist.jsx
@@ -13,12 +13,9 @@ if (!context.accountId) {
 const { fetchProjects } = VM.require(
   "${config_account}/widget/lib.projects",
 ) || {
-  fetchProjects: () => {},
+  fetchProjects: () => [],
 };
 
-if (!fetchProjects) {
-  return "";
-}
 const stars = Social.getr(
   `${context.accountId}/graph/star/*/project`,
   "final",
@@ -64,14 +61,9 @@ const starredProjectIds = starredProjects.map(
   (project) => project.split("/")[2],
 );
 
-const projects =
-  fetchProjects().filter((project) =>
-    starredProjectIds.includes(project.projectID),
-  ) || [];
-
-if (!projects) {
-  return "";
-}
+const projects = fetchProjects().filter((project) =>
+  starredProjectIds.includes(project.projectID),
+);
 
 return (
   <Widget