Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, Requests, Proposals, & More #90

Merged
merged 144 commits into from
Feb 2, 2024
Merged

Refactor, Requests, Proposals, & More #90

merged 144 commits into from
Feb 2, 2024

Conversation

elliotBraem
Copy link
Contributor

@elliotBraem elliotBraem commented Jan 24, 2024

This branch holds a pretty substantial refactor of the Build DAO gateway along with requests and proposals.

Resolves #104, #102, #83, #82, #74, #25

TODO

  • Convert home page sections into modules or a single file for fast load
  • Make navbar match current navbar w/ logo (remove inspect and notifications)
  • Red flash when navigating to feed page for first time? (I may have fixed this...)
  • There's an inconsistency with the buttons -- ButtonLink vs Button (why can't we combine these?)
  • We shouldn't be using <a></a>, instead we should be using <Link></Link>, make client side nav rerendering much smoother
  • Login button on Compose should point to "/join"
  • User !== PostHeader (this threw me off for a while), we should come up with a better organization for this (I like customActions). Could customAction use the Widget code solution you did where this widget handles state for showing modal?? @itexpert120
  • UserDropdown in header
  • Required hashtags in the feed
  • Replace fetch.daos with an SDK method (or propose to SDK if it doesn't exist yet)
  • Add library to routes
  • Add resources to routes
  • Remove about
  • Set any existing pages to point to the app with correct params (in order to not break existing links)
  • Improve proposal card rendering (Widget loading and VM.require module)
  • Fix "Propose" modal on Post

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gateway ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 6:03am

@elliotBraem elliotBraem merged commit 06c7fa1 into main Feb 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propose to DAO modal
3 participants