This repository has been archived by the owner on Jun 5, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mis-read this earlier, let's not be including these in the tree as the VSCode system is still in flux and not officially supported (e.g. just block all of the .vscode folder and leave it at that. Otherwise people are forced to use VSCode to ensure the JSON files are updated correctly when making changes even if they don't otherwise use VSCode. By allowing them into the tree we effectively make them officially part of NETMF and they must then be maintained tested and validated for each PR etc...