Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 releases #60

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

gianmarco-mameli
Copy link
Contributor

@gianmarco-mameli gianmarco-mameli commented Nov 8, 2024

Hello, I'm interested in using this check in my Icinga installation, but my vms are all Arm64, so I forked the repo and tryed to add the architecture on the goreleaser file.
The build actions worked without problems and I downloaded the Linux and Darwin bins; I've tested it in my Macmini M2 and a Debian 12 vm, and they worked fine. Unfortunately I can't test the Windows Arm64 release.
So if you want to merge this PR, I appreciate to use the Arm64 releases from your repo. In the meantime I've released the arm64 bins to start using it in my fork

Thanks

@martialblog
Copy link
Member

Ciao,

Thanks for the PR. Most our use cases are x86, thus we just had enabled by default.
I think there is nothing that prevents us from merging.

Regards,
Markus

@martialblog martialblog self-assigned this Nov 11, 2024
@martialblog
Copy link
Member

@RincewindsHat What do you think?

Copy link
Member

@RincewindsHat RincewindsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not.

@RincewindsHat RincewindsHat merged commit 20a8cca into NETWAYS:main Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants