Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode custom variable that contain special characters #19

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

martialblog
Copy link
Member

This should fix custom variables with special characters not being encoded.

See upstream repo: Mikesch-mp/icingaweb2-module-grafana#238

@martialblog martialblog added this to the Release of Fork milestone Nov 22, 2024
@martialblog martialblog self-assigned this Nov 22, 2024
@martialblog
Copy link
Member Author

@RincewindsHat I need some confirmation on this. Maybe you have larger setup with some variables to test this one?

@RincewindsHat
Copy link
Member

sure, I will test this

@RincewindsHat
Copy link
Member

Tested it, works for me (in an admitedly very much fabricated scenario).
Haven't seen any real downsides yet

@martialblog martialblog merged commit c3ee846 into main Nov 27, 2024
2 checks passed
@martialblog martialblog deleted the fix/special-chars-variables branch November 27, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants