Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodeSystem-UKCore-FundingCategory.xml #564

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

ryma2fhir
Copy link
Contributor

@ryma2fhir ryma2fhir commented Sep 30, 2024

From #550 (comment)

If we are going for a breaking change, I would then prefer Public/Private being the parent concepts with NHS England, NHS Wales, NHS Scotland, HSC Northern Ireland, NHS Isle of Man, Jersey, Guernsey and possibly Overseas Visitor under public. (As this field is meant to represent how the test is being funded, rather than where the test is taking place)

The current version of the codesystem does not match its intended use. Happy to use the codesystem as is for the purposes of the Genomics Alpha but, if possible, this should be changed in future releases

@ryma2fhir
Copy link
Contributor Author

@omarisgreat @KazeemHamzat - Is this the way you expected the Funding CodeSystem to look?

omarisgreat
omarisgreat previously approved these changes Sep 30, 2024
codesystems/CodeSystem-UKCore-FundingCategory.xml Outdated Show resolved Hide resolved
@omarisgreat
Copy link
Contributor

Also just noticed, the ConditionBodyStructure extension (structuredefinitions/Extension-UKCore-ConditionBodyStructure.xml) references a UK Core Condition, when it should reference a BodyStructure resource. Not sure if you want to bring this into this PR or add a new one

@ryma2fhir ryma2fhir merged commit 30370b4 into develop Oct 1, 2024
4 checks passed
@ryma2fhir ryma2fhir deleted the CodeSystem-UKCore-FundingCategory branch October 1, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants