Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CodeSystem-UKCore-PrimarySampleState #566

Conversation

KazeemHamzat
Copy link
Contributor

  • Rename CodeSystems-UKCore-BiopsyState to CodeSystem-UKCore-PrimarySampleState
  • Update the Concepts in UKCore-BiopsyState to Genomic MDS v1.0.4
  • JIRA Ticket: IOPS-2858

@KazeemHamzat KazeemHamzat self-assigned this Oct 7, 2024
@ryma2fhir ryma2fhir added the enhancement New feature or request label Oct 8, 2024
Copy link
Contributor

@ryma2fhir ryma2fhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KazeemHamzat
With the url changing we'd need to retire the old assets (change date and status, but not delete) and create new ones.

I'd rather keep the ValueSet name more generic in case we need to add more codesystems, or amend in future. Would the original BiopsyState still be ok? The CodeSystem is fine. The profile would also need the binding changed as well

-Retire CodeSystem-UKCore-BiopsyState and ValueSet-UKCore-BiopsyState
-Create CodeSystem-UKCore-PrimarySampleState and ValueSet-UKCore-SampleState
@KazeemHamzat KazeemHamzat force-pushed the Feature-IOPS-2858-Rename-and-update-the-Concepts-in-CodeSystems-UKCore-BiopsyState branch from 9f6b703 to a5291a1 Compare October 8, 2024 10:35
Update binding of specimen.condition to ValueSet/UKCore-SampleState
@KazeemHamzat
Copy link
Contributor Author

@KazeemHamzat With the url changing we'd need to retire the old assets (change date and status, but not delete) and create new ones.

I'd rather keep the ValueSet name more generic in case we need to add more codesystems, or amend in future. Would the original BiopsyState still be ok? The CodeSystem is fine. The profile would also need the binding changed as well

@KazeemHamzat With the url changing we'd need to retire the old assets (change date and status, but not delete) and create new ones.

I'd rather keep the ValueSet name more generic in case we need to add more codesystems, or amend in future. Would the original BiopsyState still be ok? The CodeSystem is fine. The profile would also need the binding changed as well

ValueSet name now changed to ValueSet-UKCore-SampleState to reflect names and terminologies expected in Genomic MDS v1.0.4. All the remaining modification has been effected as advised.

@KazeemHamzat KazeemHamzat requested a review from ryma2fhir October 8, 2024 11:03
Update Description for CodeSystem-UKCore-PrimarySampleState. & ValueSet-UKCore-SampleState.
Added Code Sources to the assets description.
@ryma2fhir ryma2fhir merged commit cc2ca6e into develop Oct 17, 2024
4 checks passed
@ryma2fhir ryma2fhir deleted the Feature-IOPS-2858-Rename-and-update-the-Concepts-in-CodeSystems-UKCore-BiopsyState branch October 17, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants