CCM-8114: Remove parametrisation from tests using NHS Notify Test Client #849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the intermittent test failure on internal-dev for the test 'test_not_permitted_to_use_contact_details'. The intermittent failure was caused by two tests attempting to set a rate limit value on the same client at the same time.
Removing the correlation-id aspect of the test ensures that only one test is ran using NHS Notify Client ID during the standard internal-dev test run so we can continue to run the whole test suite with 4 parallel runners without significantly compromising on the value of what is being tested.
Reviews Required
Checklist