Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-8114: Remove parametrisation from tests using NHS Notify Test Client #849

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Kennedy1265
Copy link
Contributor

@Kennedy1265 Kennedy1265 commented Jan 3, 2025

Summary

This PR resolves the intermittent test failure on internal-dev for the test 'test_not_permitted_to_use_contact_details'. The intermittent failure was caused by two tests attempting to set a rate limit value on the same client at the same time.

Removing the correlation-id aspect of the test ensures that only one test is ran using NHS Notify Client ID during the standard internal-dev test run so we can continue to run the whole test suite with 4 parallel runners without significantly compromising on the value of what is being tested.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Checklist

  • Brief description of work completed, and any technical decisions made as part of the PR
  • PR link added as a comment to the relevant JIRA ticket
  • PR link shared on Slack and/or Teams
  • 2 reviews received
  • Tester approval

Copy link

github-actions bot commented Jan 3, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-8114

Copy link
Contributor

@simonlabarere simonlabarere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think another solution would have been to make those tests use different APIM clients. Although I assume that as a tester you're happy with the removal of the correlation ID!

@Kennedy1265 Kennedy1265 merged commit 6ab0a87 into release Jan 6, 2025
6 checks passed
@Kennedy1265 Kennedy1265 deleted the feature/ccm-8114 branch January 6, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants