Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up pincode code #52

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ChristopherBacon
Copy link
Contributor

Description:
The pincode validation UI and service using Zod and React Form Hooks

Link to JIRA Ticket(s):
DSP1-1723

PR Checklist:

  • Code Quality:
    • SonarCloud's quality gate should pass
    • Code should be formatted and linted
  • Unit Tests
    • Have written unit tests (if appropriate)

@domNetco
Copy link
Contributor

domNetco commented Jan 3, 2025

Resolve this Sonarqube by changing the pin code component to use an upper case. eg pin -> Pin for the component name

image

src/app/(app)/_layout.tsx Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
25.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants