fix: Develop with stack navigation fix #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated TableRow to support both string and object testIDs - Fixed root View testID in TableRow - Updated CredentialTable snapshot to match new structure
- Updated webpack config in .storybook/main.ts to handle SVG and PNG files - Added @svgr/webpack for SVG handling - Changed TableRow to use default export - Updated CredentialTable imports to match new export style - Fixed component test imports to use default exports - Resolved test suite failures and import conflicts
- Fix Storybook configuration and module resolution - Update UI components and stories for better maintainability - Fix test setup and type definitions - Improve core application components - Update project configuration and documentation
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes several improvements to the codebase focusing on Storybook configuration, component testing, and code quality:
Storybook Improvements:
Component Updates:
Testing & Types:
Code Quality:
Manual Testing Steps:
Run Storybook to verify component stories:
Evidence:
All 56 tests passing across 13 test suites
Storybook running successfully with proper component rendering
Linting issues resolved
Link to JIRA Ticket(s): Paste links here
PR Checklist:
[x] Code Quality:
SonarCloud's quality gate should pass
Code has been formatted and linted
Removed @ts-ignore in favor of @ts-expect-error with descriptions
Fixed unused variable warnings
[x] Unit Tests
Fixed failing tests in CredentialTable.test.tsx
All 56 tests now passing
Added proper test setup configuration
This description provides: