Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changes to validation rule 36 #620

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

will-larkin-nhs
Copy link
Contributor

Description

Context

DTOSS-6045

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Contributor

@MWClayson-NHS MWClayson-NHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an associated bug with this PR?

@will-larkin-nhs
Copy link
Contributor Author

Is there an associated bug with this PR?

No, just a ticket, idrk why this change was requested

@stephhou
Copy link

stephhou commented Feb 4, 2025

Is there an associated bug with this PR?

No, just a ticket, idrk why this change was requested

It was done because currently if you have a welsh current posting then it raises this exception and is part of the reason rule 51 is getting blocked. The changes mean an exception shouldn't be raised if you have a Welsh address

MWClayson-NHS
MWClayson-NHS previously approved these changes Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants