Skip to content

Commit

Permalink
Correct the stack name
Browse files Browse the repository at this point in the history
  • Loading branch information
kris-szlapa committed Oct 8, 2024
1 parent 3f7b798 commit 34b8945
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/scripts/delete_stacks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
REPO_NAME=eps-aws-dashboards

# this should be a regex used in jq command that parses the output from aws cloudformation list-stacks and just captures stacks we are interested in
CAPTURE_REGEX="^cpt-ui-(sandbox-)?pr-(\\d+)$"
CAPTURE_REGEX="^dashboards-(sandbox-)?pr-(\\d+)$"

# this should be a regex that is used to get the pull request id from the cloud formation stack name
# this is used in a replace command to replace the stack name so what is left is just the pull request id
PULL_REQUEST_STACK_REGEX=cpt-ui-pr-
PULL_REQUEST_STACK_REGEX=dashboards-pr-

CNAME_QUERY=cpt-ui-pr
CNAME_QUERY=dashboards-pr

# this should be customised to delete cloudformation stacks and proxygen deployments if they are used
main() {
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ cdk-deploy: guard-stack_name
cdk-synth:
npx cdk synth \
--app "npx ts-node --prefer-ts-exts packages/cdk/bin/DashboardsApp.ts" \
--context stackName=cpt-ui \
--context stackName=dashboards \
--context VERSION_NUMBER=undefined \
--context COMMIT_ID=undefined \
--context epsDomain=$$epsDomain \
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ Workflows are in the `.github/workflows` folder:
- `dependabot_auto_approve_and_merge.yml` Workflow to auto merge dependabot updates.
- `pr_title_check.yml` This workflow checks the pull request title has the correct format.
- `pr-link.yml` This workflow template links Pull Requests to Jira tickets and runs when a pull request is opened.
- `pull_request.yml` Called when pull request is opened or updated. Calls package_code and release_code to build and deploy the code. Deploys to dev AWS account. The main stack deployed adopts the naming convention cpt-ui-pr-<PULL_REQUEST_ID>
- `pull_request.yml` Called when pull request is opened or updated. Calls package_code and release_code to build and deploy the code. Deploys to dev AWS account. The main stack deployed adopts the naming convention dashboards-pr-<PULL_REQUEST_ID>
- `quality_checks.yml` Runs check-licenses, lint, test and SonarCloud scan against the repo. Called from pull_request.yml and release.yml
- `release.yml` Creates a new release tag and deploys to all environments
- `cdk_package_code.yml` Packages code into a docker image and uploads to a github artifact for later deployment.
Expand Down

0 comments on commit 34b8945

Please sign in to comment.