update

NHSDigital · Jan 6, 2025 · c04a87c · c04a87c
1 parent 9f939ee
commit c04a87c
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml
@@ -27,52 +27,46 @@ jobs:
       
 
       - name: Run unittest with filenameprocessor-coverage
-        continue-on-error: true
         run: |
           pip install poetry moto==4.2.11 coverage redis botocore==1.35.49 simplejson pandas freezegun
           poetry run coverage run --source=filenameprocessor -m unittest discover -s filenameprocessor
           poetry run coverage xml -o sonarcloud-coverage-filenameprocessor-coverage.xml
-          if [[$? -ne 0]]; then exit 1; fi
+          poetry run coverage report --show-missing --skip-covered
       
       - name: Run unittest with recordprocessor-coverage
-        continue-on-error: true
         run: |
           poetry run coverage run --source=recordprocessor -m unittest discover -s recordprocessor
           poetry run coverage xml -o sonarcloud-coverage-recordprocessor-coverage.xml 
-          if [[$? -ne 0]]; then exit 1; fi
+          poetry run coverage report --show-missing --skip-covered
 
       - name: Run unittest with recordforwarder-coverage
-        continue-on-error: true
         run: |
           poetry run coverage run --source=recordforwarder -m unittest discover -s recordforwarder
           poetry run coverage xml -o sonarcloud-coverage-recordforwarder-coverage.xml
-          if [[$? -ne 0]]; then exit 1; fi
+          poetry run coverage report --show-missing --skip-covered
 
           
       - name: Run unittest with coverage-ack-lambda
-        continue-on-error: true
         run: |
           pip install poetry coverage moto==4.2.11 freezegun
           poetry run coverage run --source=ack_backend -m unittest discover -s ack_backend
           poetry run coverage xml -o sonarcloud-coverage-ack-lambda.xml
-          if [[$? -ne 0]]; then exit 1; fi
+          poetry run coverage report --show-missing --skip-covered
 
       - name: Run unittest with coverage-delta
-        continue-on-error: true
         run: |
           pip install poetry mypy-boto3-dynamodb==1.35.54 boto3==1.26.165 coverage botocore==1.29.165 jmespath==1.0.1 python-dateutil==2.9.0 urllib3==1.26.20 s3transfer==0.6.2 typing-extensions==4.12.2
           poetry run coverage run --source=delta_backend -m unittest discover -s delta_backend
           poetry run coverage xml -o sonarcloud-coverage-delta.xml
-          if [[$? -ne 0]]; then exit 1; fi
+          poetry run coverage report --show-missing --skip-covered
 
       
       - name: Run unittest with coverage-fhir-api
-        continue-on-error: true
         run: |
           pip install poetry moto==4.2.11 coverage redis botocore==1.35.49 simplejson responses structlog fhir.resources jsonpath_ng pydantic==1.10.13 requests aws-lambda-typing cffi pyjwt boto3-stubs-lite[dynamodb]~=1.26.90 python-stdnum==1.20
           poetry run coverage run --source=backend -m unittest discover -s backend
           poetry run coverage xml -o sonarcloud-coverage.xml
-          if [[$? -ne 0]]; then exit 1; fi
+          poetry run coverage report --show-missing --skip-covered
 
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master