Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMB-2337- Tech Debt - Terraform Missing Security Best Practices #316

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

ASubaran
Copy link
Contributor

@ASubaran ASubaran commented Jan 2, 2025

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2337

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 2, 2025

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2337

Copy link
Contributor

github-actions bot commented Jan 6, 2025

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2337

Copy link
Contributor

github-actions bot commented Jan 6, 2025

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2337

Copy link
Contributor

github-actions bot commented Jan 6, 2025

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2337

Copy link
Contributor

github-actions bot commented Jan 7, 2025

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2337

Copy link
Contributor

@saptarshimandal1 saptarshimandal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved.

@ASubaran ASubaran merged commit 2715e6d into master Jan 8, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants