Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMB-2382_audit_table_and_file_movement_refactor #330

Merged
merged 26 commits into from
Jan 31, 2025
Merged

AMB-2382_audit_table_and_file_movement_refactor #330

merged 26 commits into from
Jan 31, 2025

Conversation

AlexandraBenson
Copy link
Contributor

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@Valswyn-NHS Valswyn-NHS changed the title Refactor ack lambda AMB-2382_audit_table_and_file_movement_refactor Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

saptarshimandal1
saptarshimandal1 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@saptarshimandal1 saptarshimandal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved.

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital AMB JIRA Project. Here's a handy link to the ticket:

AMB-2382

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
12.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@AlexandraBenson AlexandraBenson merged commit 4014a9a into master Jan 31, 2025
7 of 8 checks passed
@AlexandraBenson AlexandraBenson deleted the AMB-2382_audit_table_and_file_movement_refactor branch January 31, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saptarshimandal1 saptarshimandal1 saptarshimandal1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandraBenson @saptarshimandal1 @Valswyn-NHS