Add private constructors to seal up util classes (#190)

NHSDigital · Dec 20, 2024 · d36bdf6 · d36bdf6
1 parent 647c60c
commit d36bdf6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/service/src/main/java/uk/nhs/adaptors/gpc/consumer/utils/LoggingUtil.java b/service/src/main/java/uk/nhs/adaptors/gpc/consumer/utils/LoggingUtil.java
@@ -2,11 +2,14 @@
 
 import static uk.nhs.adaptors.gpc.consumer.utils.HeaderConstants.SSP_TRACE_ID;
 
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
 import org.apache.commons.lang3.StringUtils;
 import org.slf4j.Logger;
 import org.springframework.http.HttpHeaders;
 import org.springframework.web.server.ServerWebExchange;
 
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
 public class LoggingUtil {
 
     private static final String MESSAGE_PREFIX = "RequestId=%s SspTraceId=%s ";

diff --git a/service/src/main/java/uk/nhs/adaptors/gpc/consumer/utils/PemFormatter.java b/service/src/main/java/uk/nhs/adaptors/gpc/consumer/utils/PemFormatter.java
@@ -5,11 +5,14 @@
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
 import org.apache.commons.lang3.StringUtils;
 
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
 public class PemFormatter {
     private static final Pattern PEM_PATTERN = Pattern.compile("(-----[A-Z ]+-----)([^-]+)(-----[A-Z ]+-----)");
     private static final int HEADER_GROUP = 1;

diff --git a/service/src/main/java/uk/nhs/adaptors/gpc/consumer/utils/UrlHelpers.java b/service/src/main/java/uk/nhs/adaptors/gpc/consumer/utils/UrlHelpers.java
@@ -3,9 +3,12 @@
 import java.net.URI;
 import java.util.List;
 
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
 import lombok.SneakyThrows;
 import org.apache.commons.lang3.ObjectUtils;
 
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
 public class UrlHelpers {
 
     public static String getUrlBase(URI uri, List<String> protocolHeader) {