Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM-494 Production pipeline setup #78

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

dlzhry2nhs
Copy link
Contributor

@dlzhry2nhs dlzhry2nhs commented Oct 19, 2023

Summary

New Feature

Following on from the first-time into prod meeting, we can now merge this. The tests in the pipeline will fail, but the environment will still build, as and when we decide to release to prod.

I'll create a ticket to do the prod release and to create a prod test app so the tests will succeed going forward. Note: this PR just creates the Prod step. Manual approval is required and an RFC before we can actually release.

See comment below. Come and have a go if you think you're hard enough to fix the tests. I gave it a go but was not up to the job.

Reviews Required

  • Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@dlzhry2nhs dlzhry2nhs marked this pull request as draft October 19, 2023 15:13
@dlzhry2nhs dlzhry2nhs changed the title Made initial changes EM-494 Production pipeline setup Oct 19, 2023
@dlzhry2nhs dlzhry2nhs merged commit 35a5767 into master Nov 7, 2023
2 checks passed
@dlzhry2nhs dlzhry2nhs deleted the feature/EM-494-prepare-prod-pipeline branch November 7, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants