Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM-494 Resolve INT pipeline #81

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

dlzhry2nhs
Copy link
Contributor

@dlzhry2nhs dlzhry2nhs commented Oct 23, 2023

Summary

  • Routine Change

Final change in this space. The fix has worked for internal-dev but not for INT. Given the output of the pipeline failure the first time, I do wonder if a dummy will still work as long as it follows a UUID format.

For now, I'm just going to add the app-id back in for INT, and add this as a question on our APIM Checklist to raise when we have the meeting for deploying into prod, since APIM are most likely to know off the top of their heads.

I'd also add that NRLF https://github.com/NHSDigital/nrl-producer-api/blob/master/azure/templates/run-smoke-tests.yml have a PROD dummy app, so it's probably just something we'll have to do.

Reviews Required

  • Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@dlzhry2nhs dlzhry2nhs merged commit d25908a into master Oct 23, 2023
2 checks passed
@dlzhry2nhs dlzhry2nhs deleted the feature/EM-494-prep-pipeline-tests-for-prod branch October 23, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants