Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/concurrent ruby rails70 testing #137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bshand
Copy link
Contributor

@bshand bshand commented Feb 6, 2025

Fix CSV parsing bug. (We were mutating the options hash to remove the :mode, but sometimes this meant we were mutating the cached result, and then passing in a nil mode subsequently. This bug has been revealed by extra checks in the latest csv library.)

Fix concurrent-ruby version to 1.3.4 for older Rails versions

Copy link
Contributor

@ollietulloch ollietulloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bshand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants