Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-5100: Backport suggested changes to template repo #29

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

m-houston
Copy link

Description

During development on the IAM AuthN PoC several issues were encountered running the scripts from the template repo, both pre-commit hooks and deployment related.

This PR contains the proposed changes which may be useful to include in the template.

  • Update terraform version to 1.8.5
  • Init terraform environments before validating
  • Fix _terraform helper function in Makefile for non-bash shells
  • Remove hidden directories from vscode config
  • Change hooks to use branch checks rather than just staged changes
  • Spelling and dictionary tweaks

Context

  • Running on M1 Mac
  • Should be tested on Windows

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Collaborator

@RossBugginsNHS RossBugginsNHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any better option than what we've done to set the envvar using /usr/bin/env? Not sure if there is a better option? are we going to flip flop on this if this doesn't work elsewhere?

@m-houston m-houston force-pushed the feature/CCM-5100-suggested-fixes branch from 794b6a2 to fd8a7b8 Compare July 10, 2024 12:59
@RossBugginsNHS RossBugginsNHS merged commit ca43476 into main Jul 10, 2024
26 checks passed
@RossBugginsNHS RossBugginsNHS deleted the feature/CCM-5100-suggested-fixes branch July 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants