Feature/CCM-6245 TFSec scanning #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesthompson26-nhs
requested review from
RossBugginsNHS,
m-houston,
aidenvaines-bjss and
timireland
as code owners
jamesthompson26-nhs
changed the title
aidenvaines-bjss
requested changes
Aug 19, 2024
jamesthompson26-nhs
force-pushed
the
feature/CCM-6245_TFSec_Scanning
branch
from
d5ad1b2 to
2a17795
Compare
sidnhs
previously approved these changes
Aug 21, 2024
sidnhs
previously approved these changes
Aug 21, 2024
aidenvaines-bjss
requested changes
Aug 21, 2024
Co-authored-by: Aiden Vaines <[email protected]>
Co-authored-by: Aiden Vaines <[email protected]>
sidnhs
approved these changes
Aug 21, 2024
aidenvaines-bjss
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a TFSec scan to the CI Commit workflow.
Context
TFSec keeps our HCL sane and secure. Builds will fail where a commit introduces a new issue of medium or above severity.
I've also removed .github from the VSCode workspace as it's something we need to actively (and relatively frequently) work on.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.