generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changes requested from Alex review (#75)
* Added mention of 'message cascades' in routing plan content for 'parallel send' feature mention. * 'or' replaced with 'and' * Message status page created - changes to /using-nhs-notify/mesh to match MESH guidance - sender IDs changed to sender names * Emma 2i requested changes * Added /using-nhs-notify/nhs-app-templates, /using-nhs-notify/email-templates, /using-nhs-notify/text-message-templates and /using-nhs-notify/letter-templates. These are based on the Confluence pages https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?spaceKey=RIS&title=3.8+Creating+letter+templates onwards, with some minor tweaks to word ordering. Romy has approved this content now. Uploaded the standardised Word doc templates for all 4 channels to /assets/worddocs, and linked to these. Craig in cyber security approved this approach (see ticket for screenshot). Updated /using-nhs-notify/personalisation in line with the Confluence page. The FAQs from onboarding indicated there's a user need to provide the PDS personalisation fields. I also added content on how users provide their own personalisation data, in line with Tan's Confluence page https://nhsd-confluence.digital.nhs.uk/display/RIS/NHS+Notify+%7C+Personalisation+Fields. In /pricing/text-messages, I replaced 'it will count as more than one message' with 'it will be charged as more than one message'. This was prompted by a comment from Romy on the text message template content. I tweaked the content to match the later version of the UI prototype, which we based on findings from user research. * Removed mention of bank holidays from emails and text message delivery times. * Removed unnecessary bullets and headings anchor links in Text message templates. Updated link text for the 4 template pages in the Using NHS Notify parent page - removed 'Creating...' from the start of each link. * Fixed typo in /text-message-templates. Removed 'Creating...' from links on /using-nhs-notify. * Updated names of Word docs to replace spaces with hyphens and make all lower case. Updated downloadable links to follow the approach Jake researched, for example [letter template]({% link assets/worddocs/letter-template-nhs-notify.docx %}) * Removed unnecessary space from line 26 on docs/pages/using-nhs-notify/letter-templates. * Update accept.txt Includes: - Noto - URL - ctrl - pending_enrichment - unnotified - permanent_failure - temporary_failure - technical_failure - precompiled - validation_failed - fullName - namePrefix - clientRef * In /using-nhs-notify/delivery-times#letters, replaced the sentence 'Once your letter has been sent, it can take...' with 'Once you've provided us with recipients' NHS numbers, it can take up to 2 working days for our suppliers to dispatch your letter'. I also added anchor links to the top of the same page, /using-nhs-notify/delivery-times, to make navigation easier. * Added content on what users need to do in order to use recipient contact details that are outside of PDS. * Emma recommendations * Removed address_line_x, clientRef, recipientContactValue and template from the bulleted list of personalisation fields from PDS as these are for internal use only. Restructured the first paragraph under ### Personal Demographics Service (PDS) personalisation fields. This was based off a conversation with Jake and it aims to clarify the link between PDS, NHS numbers and personalisation fields. * In /workspaces/nhs-notify-web-cms-dev/docs/_sass/_nhsnotify.scss I added the line 'flex-wrap: wrap;' in the following code: .nhsuk-header__navigation-list { justify-content: flex-start; flex-wrap: wrap; } This is an interim step to make the main nav list items wrap correctly when the site is viewed on a mobile device. It's not our ultimate solution but it makes the site more mobile responsive and accessible. * Removed mentions of date of birth from failed message status descriptions. Removed date of birth as as an example of a column header in a MESH request. * Added link to NHS Notify MESH documentation in /using-nhs-notify/mesh * Squashed commit of the following: commit 7b904fc Author: Ross Buggins <[email protected]> Date: Tue Nov 19 17:02:42 2024 +0000 Quick and easy js to auto hide. commit 8aed356 Author: Jake Cosgrove <[email protected]> Date: Tue Nov 19 16:05:22 2024 +0000 Developer banner and new site banner commit a3d47d2 Author: Jake Cosgrove <[email protected]> Date: Mon Nov 11 15:47:17 2024 +0000 removed phase banner and underlines from primary nav list items when hovered commit 3a30f41 Author: Jake Cosgrove <[email protected]> Date: Mon Nov 11 13:50:40 2024 +0000 removed border from phase banner commit fc61be5 Author: Jake Cosgrove <[email protected]> Date: Fri Nov 8 16:32:05 2024 +0000 Added phase banner component and related sass. Added new template for including pages of content that does not need a side-navigation. commit 45d34e6 Author: Jake Cosgrove <[email protected]> Date: Tue Nov 5 21:59:47 2024 +0000 two-third column tests * Changed first subheading to a h2 from h3 * Removed the other phase banners from Ross' test * removed phase banner includes due to component not being tested or released by developer * Alex review changes --------- Co-authored-by: Mark R <[email protected]> Co-authored-by: emmagifford <[email protected]> Co-authored-by: Ross Buggins <[email protected]>
- Loading branch information
1 parent
383fcc6
commit 32da5fa
Showing
16 changed files
with
126 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<div class="nhsuk-phase-banner" id="{{include.phase_id}}"> | ||
<div class="nhsuk-width-container"> | ||
<p class="nhsuk-phase-banner__content"> | ||
<strong class="nhsuk-tag">{{include.phase_tag}}</strong> | ||
<span class="nhsuk-phase-banner__text">{{include.phase_text}}</span> | ||
</p> | ||
</div> | ||
</div> | ||
<script> | ||
console.log("{{include.auto_hide}}") | ||
if ("{{include.auto_hide}}" == 'true' && (window.location.hostname.startsWith('notify.nhs.uk') || window.location.hostname.startsWith('127.0.0.2'))) { | ||
document.getElementById("{{ include.phase_id }}").style.visibility = 'hidden'; | ||
} | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
--- | ||
layout: default | ||
--- | ||
|
||
{% assign current_dir = page.dir %} | ||
{% assign paths = page.dir | split: "/" %} | ||
{% assign parent_dir = paths[1] %} | ||
|
||
{%- | ||
assign nav_pages = site.pages | ||
| where_exp: "item", "item.dir contains parent_dir" | ||
-%} | ||
|
||
{% assign first_level_dir = parent_dir | prepend: '/' | append: '/' %} | ||
{%- | ||
assign first_level = nav_pages | ||
| where_exp: "item", "item.dir == first_level_dir" | ||
| group_by: "section" | ||
| sort: 'name', 'last' | ||
-%} | ||
|
||
<div class="nhsuk-width-container"> | ||
<main class="nhsuk-main-wrapper" id="maincontent" role="main"> | ||
<div class="nhsuk-grid-row"> | ||
<div class="nhsnotify-pane__main-content nhsuk-grid-column-three-quarters"> | ||
{% if page.section != undefined %} | ||
<heading class="nhsuk-heading-s" style="margin-bottom: 0; color: #4c6272">{{ page.section }}</heading> | ||
{% endif %} | ||
<h1>{{ page.title }}</h1> | ||
{{ content }} | ||
</div> | ||
</div> | ||
</main> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,4 +18,6 @@ You should only use MESH to send messages if your organisation or service: | |
- only needs to send batches of messages to specific groups of recipients | ||
- does not need advanced features offered by NHS Notify API | ||
|
||
[Read our MESH documentation (opens in a new tab)](https://digital.nhs.uk/developer/api-catalogue/nhs-notify-mesh). | ||
|
||
Check if MESH is right for you by contacting our engagement team at <[email protected]>. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters