Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-5093: static landing page #24

Merged
merged 54 commits into from
Jun 19, 2024
Merged

Conversation

bhansell1
Copy link
Contributor

@bhansell1 bhansell1 commented Jun 10, 2024

Description

  • Adds NHS Theming
  • Removes just-the-docs theme
  • Adds static landing page
  • Adds some NHS components

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@bhansell1 bhansell1 requested review from a team as code owners June 10, 2024 16:01
@bhansell1 bhansell1 changed the title DRAFT: CCM-5093: static landing page CCM-5093: static landing page Jun 11, 2024
docs/_config.yml Outdated Show resolved Hide resolved
RossBugginsNHS
RossBugginsNHS previously approved these changes Jun 14, 2024
Copy link
Collaborator

@RossBugginsNHS RossBugginsNHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the accept whitelist. ! 👍

RossBugginsNHS
RossBugginsNHS previously approved these changes Jun 14, 2024
RossBugginsNHS
RossBugginsNHS previously approved these changes Jun 14, 2024
@emmagifford
Copy link
Contributor

Looks awesome, thanks so much for all your work on this Ben! 👍

Few minor things I spotted:

  • full stop needed after 'You can use NHS Notify if you work in NHS England and support direct care' (I appreciate this isn't in the prototype so you were just following that!)

  • 'all in one' need hyphenating to 'all-in-one' in the white banner near the top

  • 'in the ways that works best for them' - change 'works' to 'work'

  • the 'app' in 'NHS app' in the card at the bottom needs capitalising

  • the word 'two' needs swapping to the digit '2' in 'two sides', in the letter card at the bottom (again, I know that's how it was written in the prototype so you were only copying that)

Thanks again!

@bhansell1
Copy link
Contributor Author

Looks awesome, thanks so much for all your work on this Ben! 👍

Few minor things I spotted:

* full stop needed after 'You can use NHS Notify if you work in NHS England and support direct care' (I appreciate this isn't in the prototype so you were just following that!)

* 'all in one' need hyphenating to 'all-in-one' in the white banner near the top

* 'in the ways that works best for them' - change 'works' to 'work'

* the 'app' in 'NHS app' in the card at the bottom needs capitalising

* the word 'two' needs swapping to the digit '2' in 'two sides', in the letter card at the bottom (again, I know that's how it was written in the prototype so you were only copying that)

Thanks again!

Amazing, thanks Emma.I'll jump on that now!

Copy link

@sean-corrigan1 sean-corrigan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test evidence in comments for CCM-5093

@RossBugginsNHS
Copy link
Collaborator

Will leave comment pending for the @emmagifford and @jakecosgrove review approval

@RossBugginsNHS RossBugginsNHS self-requested a review June 19, 2024 09:44
Copy link
Collaborator

@RossBugginsNHS RossBugginsNHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore this comment

Copy link
Contributor

@jakecosgrove jakecosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, well done on this.

For next iteration: when we add the main navigation, links and buttons to the landing page, the container with the H1 and text need to be horizontally aligned to the image.
Screenshot 2024-06-19 at 15 49 38

Copy link
Contributor

@emmagifford emmagifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looks awesome! Two minor things that need tweaking please:

  • full stop after subheading 'You can use NHS Notify if you work in NHS England and support direct care
  • change word 'two' to numeral '2' in 'two sides', in the letters card at the bottom

Then good to go!

Thanks,
Emma

Copy link
Contributor

@emmagifford emmagifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore my previous comment - I needed to sync the previous changes. All looks good now!

@bhansell1 bhansell1 merged commit c0a3bbb into main Jun 19, 2024
24 checks passed
@bhansell1 bhansell1 deleted the feature/CCM-5093_static-landing-page branch June 19, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants