-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCM-5093: static landing page #24
Conversation
Signed-off-by: ben.hansell1 <[email protected]>
Signed-off-by: ben.hansell1 <[email protected]>
…m paths and change app base URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the accept whitelist. ! 👍
Looks awesome, thanks so much for all your work on this Ben! 👍 Few minor things I spotted:
Thanks again! |
Amazing, thanks Emma.I'll jump on that now! |
…. Remove banner element. Add a 1 to the page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test evidence in comments for CCM-5093
Will leave comment pending for the @emmagifford and @jakecosgrove review approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, looks awesome! Two minor things that need tweaking please:
- full stop after subheading 'You can use NHS Notify if you work in NHS England and support direct care
- change word 'two' to numeral '2' in 'two sides', in the letters card at the bottom
Then good to go!
Thanks,
Emma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ignore my previous comment - I needed to sync the previous changes. All looks good now!
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.