Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add side navigation #36

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add side navigation #36

merged 1 commit into from
Jun 20, 2024

Conversation

bhansell1
Copy link
Contributor

@bhansell1 bhansell1 commented Jun 19, 2024

Description

  • adds a temporary side nav for pages. Removing just-the-docs removed any side navigation needed to view the content pages. This is a temporary measure and a fleshed out dev ticket should still be created, brought into sprint and developed.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@bhansell1 bhansell1 requested review from a team as code owners June 19, 2024 17:48
Copy link
Collaborator

@RossBugginsNHS RossBugginsNHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to do the nested nav, take a look at this for how the nav is build up in just the docs, as I've slightly mod'd it for the internal docs site.

https://github.com/just-the-docs/just-the-docs/blob/main/_includes/components/site_nav.html

https://github.com/NHSDigital/nhs-notify-internal/blob/main/docs/_includes/components/nav.html

The referenced includes, eg sorted pages are:
https://github.com/just-the-docs/just-the-docs/blob/main/_includes/sorted_pages.html

Was debating if this makes sense at some point to put in its own GEM that's published, so had a quick play yesterday re publishing to the GitHub package manager:

https://github.com/rossBugginsNHS/my-first-gem

@RossBugginsNHS RossBugginsNHS merged commit d75cb1c into main Jun 20, 2024
38 checks passed
@RossBugginsNHS RossBugginsNHS deleted the feature/CCM-0001_sidebar-nav branch June 20, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants