Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace name, prebuilt devcontainer, livereload #39

Conversation

RossBugginsNHS
Copy link
Collaborator

@RossBugginsNHS RossBugginsNHS commented Jul 3, 2024

Including:

  • Renamed workspace to be project. Utilised settings for windows.title to set to be nice name
  • Updated to used pre built dev container
  • Removed livereload on jekyll, speeds up dev container version (F5 still works, no need to stop debugging)
  • Remove sonar properties file, confirmed they are set in action variables.
  • Added rubylsp gem for debug
  • Added custom version number generation logic.
  • Use make build in deploy pipeline.
  • Added file excludes to the .vscode settings in the website folder to hide node, bundle etc from view
  • Added "core" other folders as workspace folders
  • Exclude package.json and package lock from jekyll built output
  • Corrected jekyll config to not have 2 plugins sections
  • Upgraded pa11y versions
  • Upgraded ruby version in workflow

The dev container gets ready now in under a minute, and pages quick to respond.

Only thing I haven't tested in the deploy pipeline using the make build.


@RossBugginsNHS RossBugginsNHS requested a review from a team as a code owner July 3, 2024 17:16
@RossBugginsNHS RossBugginsNHS requested a review from a team as a code owner July 3, 2024 18:06
@RossBugginsNHS
Copy link
Collaborator Author

@bhansell1 could you test out creating a codespace from this branch please and check F5 etc to make sure the served remote pages run as well for you as seems to for me please? Cheers, Ross

@RossBugginsNHS RossBugginsNHS requested a review from bhansell1 July 4, 2024 12:18
@RossBugginsNHS RossBugginsNHS enabled auto-merge (squash) July 4, 2024 12:18
@bhansell1
Copy link
Contributor

@bhansell1 could you test out creating a codespace from this branch please and check F5 etc to make sure the served remote pages run as well for you as seems to for me please? Cheers, Ross

Runs when running in debug! It's also lightening fast compared to main! Nice changes!

bhansell1
bhansell1 previously approved these changes Jul 5, 2024
jakecosgrove
jakecosgrove previously approved these changes Jul 5, 2024
docs/package.json Outdated Show resolved Hide resolved
@RossBugginsNHS RossBugginsNHS dismissed stale reviews from jakecosgrove and bhansell1 via 674ea86 July 8, 2024 08:59
@RossBugginsNHS RossBugginsNHS disabled auto-merge July 12, 2024 08:52
@RossBugginsNHS RossBugginsNHS enabled auto-merge (squash) July 12, 2024 08:52
@RossBugginsNHS RossBugginsNHS merged commit 7a26ec9 into main Jul 12, 2024
24 checks passed
@RossBugginsNHS RossBugginsNHS deleted the rossbugginsnhs/dev-container-and-project-workspace-and-live-reload branch July 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants