Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2i checks #48

Merged
merged 5 commits into from
Aug 1, 2024
Merged

2i checks #48

merged 5 commits into from
Aug 1, 2024

Conversation

emmagifford
Copy link
Contributor

Description

Generally, added code to stop example markdown rendering so that users can copy and paste it. Also added the no TOC markdown to stop the automatic TOC generation.

Security
Changed double speech marks to single quotation marks
GDPR in full the first instance
Added no TOC markdown
Made Virtual Private Clouds lower case
NHS Notify restrict communications
Removed full stop at end of bullet
Removed oxford commas

Nhs app
Added missing sentence 'When a user selects the banner notification, this opens their message in the NHS App.'
Added 'the' before NHS App to last image caption
Changed 'that' to 'who' in 'members of the public who have the NHS App'

Text messages
Changed 'a' to 'an' in first image caption

Letters
Changed 'two sided letter' to 'double-sided letter' in caption, to match language on other pages
Changed 'Page size and layout: A4 portrait (210 x 297mm)' to 'The page size and layout is A4 portrait (210 x 297mm).'
Added apostrophe to 'recipient's address'

Pricing
Text messages
Added 'accented' before 'characters' in that column of the table at bottom to distinguish it from the table above
Changed 'each additional… characters' to 'every additional… characters'

Letters
Added hyperlink to accessible formats page
Made all '+ VAT' instances in the body texts '(plus VAT)' for consistency with other pages
Removed hyphen from second 'cross charge'
Added some contractions e.g. 'you'll', 'you've'

Using NHS Notify
MESH
Added link to MESH
Added onboarding team email

Editing and formatting
Added '' to markdown examples, to stop the markdown from rendering and keep the code visible for users to copy

Links and URLs
Changed 'Scroll down to see a guide to the available Markdown' to 'The formatting guide with the available Markdown is on the right-hand side of the page'.

Tell recipients who…
Added a heading for 'Return addresses', as this is quite a significant bit of content and it could get missed otherwise
Added link to ODS portal

Accessible formats

Added link to letter pricing page
Changed 'This is available for NHS App messages, emails, text messages and letters' to 'This is available for all message channels'
Made the '4. We’ll check for recipients with access needs' section more concise

Letters in other languages
Made the 'We'll check for recipients who need letters in other languages' section more concise

Delivery times
Updated the NHS App section in line with the Figma prototype, which has the latest content requests from App colleagues
Minor tweaks to wording - 'because there are privacy issues' > 'because of privacy issues', made 'it is' a contraction
Added line breaks in letter section to add more white space

Providing NHS numbers
Made 'Numbers' lower case in 'NHS numbers'
Amended first link to API to open in a new tab

Support
Added onboarding team email

Get started
Incorporated the onboarding email into the existing sentence

Context

Minor style changes for consistency and adding in missing links.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

… edits.

Security:
- changed double speech marks to single quotation marks
- wrote GDPR in full before acronym
- added no TOC markdown to stop bullets capitalising
- made Virtual Private Clouds lower case
- NHS Notify restrict communications - changed to restricts
- removed full stop at end of bullet
- removed Oxford comma

NHS App:
- added missing sentence 'When a user selects the banner notification, this opens their message in the NHS App.' (I'd forgotten to add this from the prototype following App colleagues' review)
- added 'the' before NHS App to last image caption
- changed 'that' to 'who' in 'members of the public who have the NHS App'

Text messages:
- changed 'a' to 'an' in first image caption

Letters:
- changed 'two sided letter' to 'double-sided letter' in caption, to match language on other pages
- changed 'Page size and layout: A4 portrait (210 x 297mm)' to 'The page size and layout is A4 portrait (210 x 297mm).'
- added apostrophe to 'recipient's address'
Security
Changed double speech marks to single quotation marks
GDPR
Added no TOC markdown
Made Virtual Private Clouds lower case
NHS Notify restrict communications
Removed full stop at end of bullet
Removed oxford commas

Nhs app
Added missing sentence 'When a user selects the banner notification, this opens their message in the NHS App.'
Added 'the' before NHS App to last image caption
Changed 'that' to 'who' in 'members of the public who have the NHS App'

Text messages
Changed 'a' to 'an' in first image caption

Letters
Changed 'two sided letter' to 'double-sided letter' in caption, to match language on other pages
Changed 'Page size and layout: A4 portrait (210 x 297mm)' to 'The page size and layout is A4 portrait (210 x 297mm).'
Added apostrophe to 'recipient's address'

Pricing
Text messages
Added 'accented' before 'characters' in that column of the table at bottom to distinguish it from the table above
Changed 'each additional… characters' to 'every additional… characters'

Letters
Added hyperlink to accessible formats page
Made all '+ VAT' instances in the body texts '(plus VAT)' for consistency with other pages
Removed hyphen from second 'cross charge'
Added some contractions e.g. 'you'll', 'you've'

Using NHS Notify
MESH
Added link to MESH
Added onboarding team email

Editing and formatting
Struggling to get no TOC code to work - needs picking up, chased with devs
Added '<code>' to markdown examples, to stop the markdown from rendering and keep the code visible for users to copy

Links and URLs
Changed 'Scroll down to see a guide to the available Markdown' to 'The formatting guide with the available Markdown is on the right-hand side of the page'.

Tell recipients who…
We should probably add a heading for 'Return addresses' - didn't want to add this in just yet as it's getting pulled into the automatic TOC for things we can change, making it look like users can change return addresses
Added link to ODS portal

Accessible formats

Added link to letter pricing page
Changed 'This is available for NHS App messages, emails, text messages and letters' to 'This is available for all message channels'
Made the '4. We’ll check for recipients with access needs' section more concise

Letters in other languages
Made the 'We'll check for recipients who need letters in other languages' section more concise

Delivery times
Updated the NHS App section in line with the Figma prototype, which has the latest content requests from App colleagues
Minor tweaks to wording - 'because there are privacy issues' > 'because of privacy issues', made 'it is' a contraction
Added line breaks in letter section to add more white space
…table of contents being added

Providing NHS numbers
Made 'Numbers' lower case in 'NHS numbers'
Amended first link to API to open in a new tab

Support
Added onboarding team email

Get started
Incorporated the onboarding email into the existing sentence
@emmagifford emmagifford requested review from a team as code owners July 30, 2024 08:56
@jakecosgrove jakecosgrove merged commit 8132afa into main Aug 1, 2024
38 checks passed
@jakecosgrove jakecosgrove deleted the 2i-checks branch August 1, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants