Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New templating pages + message and channel status page + updates to 6 pages #64

Closed
wants to merge 18 commits into from

Conversation

emmagifford
Copy link
Contributor

Description

This merge includes new pages:

  • NHS App templates
  • Email templates
  • Text message templates
  • Letter templates
  • Message and channel status

Changes made to:

  • Features
  • Routing plans
  • Sender names (was 'Sender IDs')
  • Tell us who you want to message (was 'Providing NHS numbers')
  • Personalisation
  • MESH

My latest commits address the comments from Jake's latest review and a few lingering issues. These changes are:

  • removed anchor links for bullets and headings in /text-message-templates as these sections don't exist for this channel
  • removed 'Creating...' from the start of the hypertext for the 4 new pages linked to in /using-nhs-notify parent page
  • fixed a copy and paste typo - replaced 'to send your email' with 'to send your text message' in /text-message-templates, just below the heading 'How to edit your NHS App message using our template'
  • updated Word doc names (replaced spaces with hyphens and made all lower case) then updated the downloadable links on the 4 templating pages to follow the approach Jake researched, for example [letter template]({% link assets/worddocs/letter-template-nhs-notify.docx %})

Context

There is an updated templating process that we need to communicate.

This change also incorporates updates from SMEs about various other topics. We've built up a backlog of changes that need publishing.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

mark-r-bjss and others added 16 commits October 10, 2024 15:56
CCM-5869: Create accessibility statement page (NHSDigital#58)
Added mention of 'message cascades' in routing plan content for 'para…
- changes to /using-nhs-notify/mesh to match MESH guidance
- sender IDs changed to sender names
Message and channel status page + other edits
…mplates, /using-nhs-notify/text-message-templates and /using-nhs-notify/letter-templates.

These are based on the Confluence pages https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?spaceKey=RIS&title=3.8+Creating+letter+templates onwards, with some minor tweaks to word ordering. Romy has approved this content now.

Uploaded the standardised Word doc templates for all 4 channels to /assets/worddocs, and linked to these. Craig in cyber security approved this approach (see ticket for screenshot).

Updated /using-nhs-notify/personalisation in line with the Confluence page. The FAQs from onboarding indicated there's a user need to provide the PDS personalisation fields.

I also added content on how users provide their own personalisation data, in line with Tan's Confluence page https://nhsd-confluence.digital.nhs.uk/display/RIS/NHS+Notify+%7C+Personalisation+Fields.

In /pricing/text-messages, I replaced 'it will count as more than one message' with 'it will be charged as more than one message'. This was prompted by a comment from Romy on the text message template content. I tweaked the content to match the later version of the UI prototype, which we based on findings from user research.
…lisation-update

Creating templates guidance + personalisation updates + text message pricing update
Removed mention of bank holidays from emails and text message delivery times
… templates.

Updated link text for the 4 template pages in the Using NHS Notify parent page - removed 'Creating...' from the start of each link.
…l lower case. Updated downloadable links to follow the approach Jake researched, for example [letter template]({% link assets/worddocs/letter-template-nhs-notify.docx %})
Ignoring the 'English usage commit check' as it's not consistent to the GOV.UK / NHS style guide. 'URL' is to be written in full capitals.
@emmagifford emmagifford requested a review from a team as a code owner October 24, 2024 13:35
jakecosgrove
jakecosgrove previously approved these changes Oct 25, 2024
Copy link
Contributor

@jakecosgrove jakecosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve and ignore the english checks as URL is being used correctly according to the GOV.UK/ NHS content style guides.

Well done on getting this out, being patient and fixing all the issues that we can on our side.

Includes:
- Noto
- URL
- ctrl
- pending_enrichment
- unnotified
- permanent_failure
- temporary_failure
- technical_failure
- precompiled
- validation_failed
- fullName
- namePrefix
- clientRef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants