generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New templating pages + message and channel status page + updates to 6 pages #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCM-5869: Create accessibility statement page (NHSDigital#58)
…llel send' feature mention.
Added mention of 'message cascades' in routing plan content for 'para…
- changes to /using-nhs-notify/mesh to match MESH guidance - sender IDs changed to sender names
Message and channel status page + other edits
…mplates, /using-nhs-notify/text-message-templates and /using-nhs-notify/letter-templates. These are based on the Confluence pages https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?spaceKey=RIS&title=3.8+Creating+letter+templates onwards, with some minor tweaks to word ordering. Romy has approved this content now. Uploaded the standardised Word doc templates for all 4 channels to /assets/worddocs, and linked to these. Craig in cyber security approved this approach (see ticket for screenshot). Updated /using-nhs-notify/personalisation in line with the Confluence page. The FAQs from onboarding indicated there's a user need to provide the PDS personalisation fields. I also added content on how users provide their own personalisation data, in line with Tan's Confluence page https://nhsd-confluence.digital.nhs.uk/display/RIS/NHS+Notify+%7C+Personalisation+Fields. In /pricing/text-messages, I replaced 'it will count as more than one message' with 'it will be charged as more than one message'. This was prompted by a comment from Romy on the text message template content. I tweaked the content to match the later version of the UI prototype, which we based on findings from user research.
…lisation-update Creating templates guidance + personalisation updates + text message pricing update
Removed mention of bank holidays from emails and text message delivery times
… templates. Updated link text for the 4 template pages in the Using NHS Notify parent page - removed 'Creating...' from the start of each link.
…ks on /using-nhs-notify.
…l lower case. Updated downloadable links to follow the approach Jake researched, for example [letter template]({% link assets/worddocs/letter-template-nhs-notify.docx %})
…/letter-templates.
Ignoring the 'English usage commit check' as it's not consistent to the GOV.UK / NHS style guide. 'URL' is to be written in full capitals.
jakecosgrove
previously approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve and ignore the english checks as URL is being used correctly according to the GOV.UK/ NHS content style guides.
Well done on getting this out, being patient and fixing all the issues that we can on our side.
Includes: - Noto - URL - ctrl - pending_enrichment - unnotified - permanent_failure - temporary_failure - technical_failure - precompiled - validation_failed - fullName - namePrefix - clientRef
…tch-1 Update accept.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge includes new pages:
Changes made to:
My latest commits address the comments from Jake's latest review and a few lingering issues. These changes are:
Context
There is an updated templating process that we need to communicate.
This change also incorporates updates from SMEs about various other topics. We've built up a backlog of changes that need publishing.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.