Sender name updates, minor styling and mobile responsiveness fixes #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCM-5869: Create accessibility statement page (NHSDigital#58)
…llel send' feature mention.
Added mention of 'message cascades' in routing plan content for 'para…
- changes to /using-nhs-notify/mesh to match MESH guidance - sender IDs changed to sender names
Message and channel status page + other edits
…mplates, /using-nhs-notify/text-message-templates and /using-nhs-notify/letter-templates. These are based on the Confluence pages https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?spaceKey=RIS&title=3.8+Creating+letter+templates onwards, with some minor tweaks to word ordering. Romy has approved this content now. Uploaded the standardised Word doc templates for all 4 channels to /assets/worddocs, and linked to these. Craig in cyber security approved this approach (see ticket for screenshot). Updated /using-nhs-notify/personalisation in line with the Confluence page. The FAQs from onboarding indicated there's a user need to provide the PDS personalisation fields. I also added content on how users provide their own personalisation data, in line with Tan's Confluence page https://nhsd-confluence.digital.nhs.uk/display/RIS/NHS+Notify+%7C+Personalisation+Fields. In /pricing/text-messages, I replaced 'it will count as more than one message' with 'it will be charged as more than one message'. This was prompted by a comment from Romy on the text message template content. I tweaked the content to match the later version of the UI prototype, which we based on findings from user research.
…lisation-update Creating templates guidance + personalisation updates + text message pricing update
Removed mention of bank holidays from emails and text message delivery times
… templates. Updated link text for the 4 template pages in the Using NHS Notify parent page - removed 'Creating...' from the start of each link.
…ks on /using-nhs-notify.
…l lower case. Updated downloadable links to follow the approach Jake researched, for example [letter template]({% link assets/worddocs/letter-template-nhs-notify.docx %})
…/letter-templates.
Ignoring the 'English usage commit check' as it's not consistent to the GOV.UK / NHS style guide. 'URL' is to be written in full capitals.
Includes: - Noto - URL - ctrl - pending_enrichment - unnotified - permanent_failure - temporary_failure - technical_failure - precompiled - validation_failed - fullName - namePrefix - clientRef
…tch-1 Update accept.txt
…nce your letter has been sent, it can take...' with 'Once you've provided us with recipients' NHS numbers, it can take up to 2 working days for our suppliers to dispatch your letter'. I also added anchor links to the top of the same page, /using-nhs-notify/delivery-times, to make navigation easier.
Letter delivery times update + anchor links
…act details that are outside of PDS.
PDS override content + page name tidy-up
Update from upstream
… from the bulleted list of personalisation fields from PDS as these are for internal use only. Restructured the first paragraph under ### Personal Demographics Service (PDS) personalisation fields. This was based off a conversation with Jake and it aims to clarify the link between PDS, NHS numbers and personalisation fields.
…ded the line 'flex-wrap: wrap;' in the following code:
.nhsuk-header__navigation-list {
justify-content: flex-start;
flex-wrap: wrap;
}
This is an interim step to make the main nav list items wrap correctly when the site is viewed on a mobile device. It's not our ultimate solution but it makes the site more mobile responsive and accessible.
PDS personalisation fields updates + main nav wrapping
…ions. Removed date of birth as as an example of a column header in a MESH request.
commit 7b904fc Author: Ross Buggins <[email protected]> Date: Tue Nov 19 17:02:42 2024 +0000 Quick and easy js to auto hide. commit 8aed356 Author: Jake Cosgrove <[email protected]> Date: Tue Nov 19 16:05:22 2024 +0000 Developer banner and new site banner commit a3d47d2 Author: Jake Cosgrove <[email protected]> Date: Mon Nov 11 15:47:17 2024 +0000 removed phase banner and underlines from primary nav list items when hovered commit 3a30f41 Author: Jake Cosgrove <[email protected]> Date: Mon Nov 11 13:50:40 2024 +0000 removed border from phase banner commit fc61be5 Author: Jake Cosgrove <[email protected]> Date: Fri Nov 8 16:32:05 2024 +0000 Added phase banner component and related sass. Added new template for including pages of content that does not need a side-navigation. commit 45d34e6 Author: Jake Cosgrove <[email protected]> Date: Tue Nov 5 21:59:47 2024 +0000 two-third column tests
Squashed commit of the following
Phase banner quick fix
…ream Robu6/2024 12 13/merge in upstream
…leased by developer
Hidden 'developer' phase banner
Fix branch
Aligning web-cms with web-cms-dev (NHSDigital#77)
- corrected typo's - added missing anchor link - included image of example inbox showing sender name and 'from' address
Sender name guidance updates
… appear for NHS App and SMS. This commit includes additional images to support user understanding of sender names and where they sit in context.
- new HTML includes specific for images with captions so they fit 100% of their container - images on pages use new includes - inset text has override style class to reduce margin-top - side nav now disappears when below 768px breakpoint (need to talk to design team about mobile solution)
Styling and responsive fixes
…ms-dev into Sender-name-updates Merge web-cms-dev main with sender-name-updates branch
Sender name updates 2
emmagifford
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
2i complete. Checked the files changed tab and can see that this PR includes all the relevant updates from previous commits on the dev repo:
-updated image and caption component for all images across the site
-inset text spacing
-temporary side nav mobile responsiveness fix
-3 new images showing sender names
-content updates to /tell-recipients-who-your-messages-are-from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following tickets:
There are also some minor changes to styling, including:
Context
Sender name content changes
Users of NHS Notify need guidance to choose appropriate sender names for each channel they use to send messages with.
Each message channel has their own considerations and processes to use in order to create an approved sender name.
This content provides additional guidance for users to make more informed decisions on the sender names of message channels they want to use.
It has been reviewed and approved by the NHS Notify onboarding team.
Styling changes
These changes address most of the tickets included in CCM-7534 CMS Improvements.
It does not fully address how we present the side navigation to mobile users: this PR just hides the side navigation from mobile viewports.
This PR also does not include an updated primary navigation component that is fully responsive to mobile views and matches the interaction of the header component in the NHS Design system
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.