Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies policy #89

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Cookies policy #89

merged 4 commits into from
Feb 26, 2025

Conversation

jakecosgrove
Copy link
Contributor

Description

Publishes the /cookies page for the Web UI and includes a link to the page in the footer

Context

For the MVP release of the Web UI, a cookies policy is needed in order to be compliant with legislation on the use of cookies.

The cookies page tells users when and how we use cookies in the Web UI.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jakecosgrove jakecosgrove requested a review from a team as a code owner February 26, 2025 13:58
- footer unordered list fix
- section headers added as list items instead of paragraphs
Copy link
Contributor

@emmagifford emmagifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2i checks complete.

New cookies page looks good - headings, body text and table all look fine.

I also checked the 2 accessibility fixes Jake and Alex did following Alex's internal audit:

  • can see that the missing </ul> tag is now added to footer
  • paragraph <p class="nhsuk-u-font-weight-bold nhsnotify-side-nav__list-section"> is now not directly inside <ul>

@emmagifford emmagifford merged commit e642f7a into main Feb 26, 2025
25 checks passed
@emmagifford emmagifford deleted the cookies-policy branch February 26, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants