[Template Sync] Drift from template-repository remediation #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mark-r-bjss
reviewed
Oct 1, 2024
| group_target-env.tfvars | ||
|
|
||
| .amplify/ | ||
| amplify_outputs.json |
There was a problem hiding this comment.
This must not be removed from the gitignore.
There was a problem hiding this comment.
Files can be added to scripts/config/.repository-template-sync-ignore
mark-r-bjss
reviewed
Oct 1, 2024
|
|
||
| @app.route("/") | ||
| def index(): | ||
| return "Hello World!" |
There was a problem hiding this comment.
Lets not add unnecessary code into the repo.
There was a problem hiding this comment.
Agree Files can be added to scripts/config/.repository-template-sync-ignore
mark-r-bjss
requested changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resultant drift from repository template
Who should respond to this PR?
The team which owns the responsibility for this component repository. You may want to consult other contributors.
How to progress this PR
The repositories guardians should review the contents of the PR and decide how to proceed, you may wish to back-out certain changes or accept them from the upstream
nhsdigital/nhs-notify-repository-templaterepository.If there are changes you do not wish to see again, it is recommended you add exclusions to
scripts/config/.repository-template-sync-ignore.