generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCM-7572: Implement delete template #234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:03 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:03 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:03 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:03 — with
GitHub Actions
Inactive
chris-elliott-nhsd
had a problem deploying
to
dev
December 19, 2024 16:08 — with
GitHub Actions
Failure
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:08 — with
GitHub Actions
Inactive
chris-elliott-nhsd
had a problem deploying
to
dev
December 19, 2024 16:09 — with
GitHub Actions
Failure
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:09 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:12 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:12 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:13 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
December 19, 2024 16:13 — with
GitHub Actions
Inactive
chris-elliott-nhsd
force-pushed
the
feature/CCM-7572_delete-template
branch
from
January 3, 2025 12:07
d6ea258
to
6e01108
Compare
Ian-Hodges
reviewed
Jan 3, 2025
mark-r-bjss
reviewed
Jan 3, 2025
We should update backend validation to make sure that we are not saving already-deleted templates or creating any in a deleted state. We should also validate that the ttl is set whenever the status is deleted. Happy to split some of this off into a ticket to introduce optimistic locking. |
chris-elliott-nhsd
changed the title
DRAFT: CCM-7572: Implement delete template
CCM-7572: Implement delete template
Jan 6, 2025
mark-r-bjss
previously approved these changes
Jan 6, 2025
Ian-Hodges
previously approved these changes
Jan 6, 2025
ClareJonesBJSS
previously approved these changes
Jan 6, 2025
chris-elliott-nhsd
dismissed stale reviews from ClareJonesBJSS, Ian-Hodges, and mark-r-bjss
via
January 7, 2025 17:04
35eed19
gparry333
approved these changes
Jan 8, 2025
Ian-Hodges
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add the option to delete a template from the manage templates page
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.