CCM-7465: implement backend api and update automated tests PT.2 #240
Conversation
| @@ -7,6 +7,8 @@ const domain = process.env.NOTIFY_DOMAIN_NAME ?? 'localhost:3000'; | |||
|
|
|||
| const nextConfig = (phase) => { | |||
| const isDevServer = phase === PHASE_DEVELOPMENT_SERVER; | |||
| const includeAuthPages = | |||
There was a problem hiding this comment.
I've added this in because the automated tests running in CI do a production build of the we application.
This build does not include the the auth pages. So we're unable to login to the app.
I'm not entirely happy with it. Any alternative suggestions would be great.
--
In the automated tests we take what is effectively a snapshot of the cookies and store them in a file called user.json. This information is then passed into the browser context on each test run.
See this comment -> #240 (comment)
bhansell1
changed the title
|
|
||
| # Includes auth pages when building web frontend. This is needed in CI for the automated tests | ||
| # which run the app in production mode. | ||
| INCLUDE_AUTH_PAGES='' |
There was a problem hiding this comment.
See -> #240 (comment)
| } | ||
| return aCreatedAt < bCreatedAt ? 1 : -1; | ||
| }); | ||
| const sortedData = data.sort((a, b) => { |
There was a problem hiding this comment.
TODO: Re-add isValidTemplate and update the function to accept TemplateDTO
| @@ -34,5 +34,7 @@ resource "aws_amplify_app" "main" { | |||
| NEXT_PUBLIC_DISABLE_CONTENT = var.disable_content | |||
| AMPLIFY_MONOREPO_APP_ROOT = "frontend" | |||
| BACKEND_API_URL = module.backend_api.api_base_url | |||
| COGNITO_USER_POOL_ID = jsondecode(data.aws_ssm_parameter.cognito_config.value)["USER_POOL_ID"] | |||
There was a problem hiding this comment.
I don't think this is correct getting the values out like this.
Any suggestions on a better way to do it?
|
|
||
| Amplify.configure(amplifyConfig, { ssr: true }); | ||
| Amplify.configure(AMPLIFY_OUTPUTS(), { ssr: true }); |
There was a problem hiding this comment.
I'm unsure why but calling AMPLIFY_OUTPUTS() causes the cognito login page to say "Cognito not configured".
You can do a Amplify.getConfig right after this call and see that it's been set correctly.
The only way I've seen to work around this is to NOT called process.env.COGNITO_USER_POOL_ID and instead use a string literal.
| timeout-minutes: 10 | ||
| steps: | ||
| - name: "Checkout code" | ||
| uses: actions/checkout@v4 | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| name: amplify_outputs.json | ||
| path: frontend/ | ||
| name: sandbox_tf_outputs.json |
There was a problem hiding this comment.
I'm trying to read in this output files in the automated tests. But I get a pipeline failure saying values are undefined.
So I assume this file get put in the wrong place.
There was a problem hiding this comment.
We'll also need to set the COGNITO_USER_POOL_ID and COGNITO_USER_POOL_CLIENT_ID somewhere for the web-app.
| @@ -0,0 +1,8 @@ | |||
| export const AMPLIFY_OUTPUTS = () => ({ | |||
There was a problem hiding this comment.
My intention here was to have a single place for Amplify outputs driven by environment variables.
But that doesn't seem to work with Amplify. Only string literals appear to work.
So this idea might need to be scrapped and we generate our own amplify_ouputs.json file probably via generate-dependencies?
| @@ -0,0 +1,18 @@ | |||
| /* | |||
There was a problem hiding this comment.
Bit of a weird one
When running the web-app in dev mode npm run dev then running ALL the automated tests. The component tests become flakey.
Running the web-app in production mode npm run buld && npm run start the tests pass quickly and are not flakey.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.