Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-5100: Revert changes to the way page titles are displayed #49

Closed
wants to merge 4 commits into from
Closed

CCM-5100: Revert changes to the way page titles are displayed #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d40f4e0
CCM-5100: Revert changes to the way page titles are displayed
m-houston Jul 17, 2024
2d6d913
CCM-5100: Make first heading in MD file H1 to satisfy linter
m-houston Jul 17, 2024
2c1fce3
CCM-5100: Remove hard-coded codeowners
m-houston Oct 16, 2024
1ea7f8d
CCM-5100: Use AMET team as default codeowner
m-houston Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# NHS Notify Code Owners

* @rossbugginsnhs @m-houston @edmundcraske2-nhs @timireland
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RossBugginsNHS - view on hard-coded vs team based code owners? We have several places where this is currently hard coded and needs updating.

* @NHSDigital/nhs-notify-amet

# Default protection for codeowners, must be last in file.
/.github/CODEOWNERS @NHSDigital/nhs-notify-code-owners
Expand Down
4 changes: 2 additions & 2 deletions docs/_includes/page-info-header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
assign wordWarning = 200 %} {% assign wordCount = content | number_of_words%} {%
assign readTime = wordCount | divided_by: 100.0 | ceil %} {% if page.sub_title
%}
<h1>{{ page.name }}</h1>
<h1>{{ page.title }}</h1>
<p class="text-medium text-grey-dk-300 mb-0">{{ page.summary }}</p>
{% else %}
<h1>{{ page.name }}</h1>
<h1>{{ page.title }}</h1>
{% endif %}

<div class="page-info">
Expand Down
3 changes: 1 addition & 2 deletions docs/collections/_repos/nhs-notify-iam-webauth.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
---
repo-name: nhs-notify-iam-webauth
owners: [ "rossbugginsnhs", "m-houston" ]
title: nhs-notify-iam-webauth
name: Notify IAM Web Authentication
description: OIDC Authentication Micro-Frontend for Web UI
author: "Mike Houston"
order: 3
parent: Repositories
---

### Purpose
# Purpose

This repository contains a Micro-Frontend (MFE) web application which handles user login using a Cognito User Pool

Expand Down
Loading