Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to Manage users and Vaccine batches #114

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

frankieroberto
Copy link
Collaborator

@frankieroberto frankieroberto commented Sep 23, 2024

This adds a pagination component to the bottom of the Manage users page, rather than just displaying all users on a single page.

The number of users per page is set at 20, although this could be tweaked.

The pagination component is not yet part of the NHS design system, so I’ve borrowed the GOV.UK one and applied NHS styling. This is still work-in-progress, and I’m working on contributing this to the NHS design system here: nhsuk/nhsuk-frontend#1026

Screenshots

Manage users

First page Middle page Last page
manage-users-page-1 manage-users-page-3 manage-users-page-5

Vaccine batches (on vaccine product page for a given site)

pagination-of-vaccine-batches

If there are a lot of pages, then ellipsis would be used to show gaps in the sequence, so that the first page, last page, previous and next page are always included:

Screenshot 2024-09-23 at 16 09 43

@frankieroberto frankieroberto temporarily deployed to record-a-vac-add-pagina-bzogwn September 23, 2024 15:11 Inactive
@frankieroberto frankieroberto changed the title Add pagination to Manage users Add pagination to Manage users and Vaccine batches Sep 23, 2024
@frankieroberto frankieroberto temporarily deployed to record-a-vac-add-pagina-bzogwn September 24, 2024 13:08 Inactive
@frankieroberto frankieroberto temporarily deployed to record-a-vac-add-pagina-bzogwn September 24, 2024 13:32 Inactive
@frankieroberto frankieroberto marked this pull request as ready for review September 24, 2024 13:46
Copy link
Collaborator

@johnrimmer2 johnrimmer2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N/A

@frankieroberto frankieroberto merged commit be0609d into main Oct 24, 2024
@frankieroberto frankieroberto deleted the add-pagination branch October 24, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants