Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding notes on how to remove sensitive data that has leaked into a r… #304

Merged
merged 3 commits into from
Oct 19, 2023
Merged

adding notes on how to remove sensitive data that has leaked into a r… #304

merged 3 commits into from
Oct 19, 2023

Conversation

walteck
Copy link
Contributor

@walteck walteck commented Oct 2, 2023

…epository

@walteck walteck requested a review from a team as a code owner October 2, 2023 13:47
stefaniuk
stefaniuk previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@stefaniuk stefaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

stefaniuk
stefaniuk approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@stefaniuk stefaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regularfry
Copy link
Contributor

There's a problem here with the markdown link checker. It's saying some of the links into the azure docs are broken (https://azure.microsoft.com/en-us/blog/introducing-the-microsoft-azure-wellarchitected-framework/, for instance) when as far as I can see they're fine.

It's also saying the link to https://owasp.org/www-project-zap/ is bust, which it is, so that needs fixing.

@walteck walteck merged commit 3659ffd into main Oct 19, 2023
1 check failed
@walteck walteck deleted the cw-commit-purge branch October 19, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefaniuk stefaniuk stefaniuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walteck @regularfry @stefaniuk