Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no declaration for TuyauProvider #28

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

limwa
Copy link
Member

@limwa limwa commented Jan 5, 2025

For some reason, in v0.0.8, @tuyau/inertia stopped shipping .d.ts files.

Check build folder in https://www.npmjs.com/package/@tuyau/inertia/v/0.0.7?activeTab=code vs https://www.npmjs.com/package/@tuyau/inertia/v/0.0.8?activeTab=code.

@limwa limwa requested a review from a team January 7, 2025 04:35
Copy link
Contributor

@AvilaAndre AvilaAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuayu/inertia 0.0.8 added support for InertiaJS 2, which supports React ^19.0.0, but version 0.0.7 only supports up to React ^18.3.1.

@AvilaAndre
Copy link
Contributor

@tuayu/inertia 0.0.8 added support for InertiaJS 2, which supports React ^19.0.0, but version 0.0.7 only supports up to React ^18.3.1.

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/react
npm error   react@"^19.0.0" from the root project
npm error   peer react@"^16.9.0 || ^17.0.0 || ^18.0.0 || ^19.0.0" from @inertiajs/[email protected]
npm error   node_modules/@inertiajs/react
npm error     @inertiajs/react@"^2.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional react@"^18.3.1" from @tuyau/[email protected]
npm error node_modules/@tuyau/inertia
npm error   @tuyau/inertia@"^0.0.7" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution

@limwa
Copy link
Member Author

limwa commented Jan 7, 2025

We have other dependencies that don't have React 19 in their peer dependencies. Furthermore, React 19 is still very compatible with React 18.

I haven't had problems using tuyau 0.0.7, but I understand the concern.

I still think we should merge this anyways and wait for a release that fixes this later!

Copy link
Contributor

@AvilaAndre AvilaAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case :)

@limwa limwa merged commit ff36a85 into main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants